Add font: fontFamily.GTA to link styles #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be extra sure the font is correct, can you try using a lowercase "g" in the blue font? It's easy to tell if it's our font, it will look like this: |
|
Yes, it looks like from the screenshots the font is still not correct. If you look at the link for "Forgot?" it does not show the "g" like Shawn pointed out. |
|
@shawnborton @tgolen Was working too fast and used the wrong CSS rule name 😅 Should be fixed now and good for another review, thanks a lot! I've updated the screenshots too. |
shawnborton
approved these changes
Apr 7, 2021
tgolen
approved these changes
Apr 7, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link styles were missing our branding font, so I added it to the styles.
Fixed Issues
#1910
Tests
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
cc @shawnborton