Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expensify-common hash to support brackets in links #2277

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

alex-mechler
Copy link
Contributor

Details

Updates the expensify-common hash for this pr Expensify/expensify-common#360

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/153365

Tests / QA

  1. Send the message
* [[Expensify.org] On-duty rotation](https://github.com/Expensify/Expensify/issues/148105) - this one is a little more complex as well
  1. Verify it links correctly
    image
    image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@alex-mechler alex-mechler requested a review from a team April 7, 2021 18:54
@alex-mechler alex-mechler self-assigned this Apr 7, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team April 7, 2021 18:54
@ctkochan22 ctkochan22 merged commit 6d14c36 into master Apr 7, 2021
@ctkochan22 ctkochan22 deleted the amechler-expensify-common-hash branch April 7, 2021 21:11
@OSBotify
Copy link
Contributor

OSBotify commented Apr 7, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants