Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Settings] Allow users to add secondary logins (followup) #2251

Merged
merged 1 commit into from
Apr 7, 2021
Merged

[User Settings] Allow users to add secondary logins (followup) #2251

merged 1 commit into from
Apr 7, 2021

Conversation

Maftalion
Copy link
Contributor

@Maftalion Maftalion commented Apr 7, 2021 •
edited
Loading

Details

Fixed Issues

Fixes https://github.com//issues/2029

@Maftalion Maftalion requested a review from a team as a code owner April 7, 2021 00:15
@MelvinBot MelvinBot requested review from deetergp and removed request for a team April 7, 2021 00:15
@Maftalion
Copy link
Contributor Author

@tgolen @NikkiWines

@tgolen
Copy link
Contributor

tgolen commented Apr 7, 2021

Thank you for submitting these!

deetergp
deetergp approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/**
 * I love comments! Looks good to me!
 */

@deetergp deetergp merged commit f0b220a into Expensify:master Apr 7, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Apr 7, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Maftalion @tgolen @OSBotify @deetergp