Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Safari- Page gets distorted tapping add phone number in profile #3604

Closed
kavimuru opened this issue Jun 16, 2021 · 11 comments · Fixed by #3719
Closed

mWeb - Safari- Page gets distorted tapping add phone number in profile #3604

kavimuru opened this issue Jun 16, 2021 · 11 comments · Fixed by #3719
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.expensify.cash and login
  2. Tap avatar
  3. Tap profile
  4. Tap add phone number

Expected Result:

Add phone number page opens to enter phone number and password

Actual Result:

Page looks distorted, Partially displaying the add phone number page

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.69-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
IMG_5858

Bug5114980_IMG_5863.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jun 16, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@NikkiWines
Copy link
Contributor

Can reproduce on a sim, going to look into what commit might've introduced this:

@NikkiWines
Copy link
Contributor

Exists for me on commit c5e6da221 (which is the merge commit for #3193) but doesn't exist on e4bd83e23, the commit before it. Looks like src/pages/settings/AddSecondaryLoginPage.js was modified in that PR too.

image

cc: @roryabraham looks like @parasharrajat's PR may have introduced this

@parasharrajat
Copy link
Member

Thanks, @NikkiWines I think the same. There are issues on the safari M-web and all other platforms are good. I will look into it.

@NikkiWines NikkiWines removed their assignment Jun 16, 2021
@roryabraham
Copy link
Contributor

@parasharrajat Any information here?

@parasharrajat
Copy link
Member

Checking all the safari issues now. I will try to fix them one by one.

@tgolen
Copy link
Contributor

tgolen commented Jun 22, 2021

@parasharrajat this issue is blocking deploys and should be the absolute top priority. What is the status of this? How can I help?

@parasharrajat
Copy link
Member

Ok. I'll take it first. I think I know what I need to do here.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 22, 2021

@parasharrajat and I talked about this a bit 1:1 ... PR is up

TL;DR it works perfectly on simulator, but on the actual iPhone the keyboard may not open, despite the input being focused correctly. But it does solve this problem.

@isagoico
Copy link

isagoico commented Jun 23, 2021

Tested this on iOS and confirmed it's working on 1.0.73-2 🎉
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants