-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for Payment August 4th] IOU - Autofocus 'What's it for?' text box in details page #4215
Comments
Triggered auto assignment to @bondydaa ( |
If you make it ProposalIn components/IOUConfirmationList add |
Proposal
|
Hmm, why? It just returns
|
|
Feel pretty confident since we've already got 2 contributors commenting that we can make this External 😁 . I do see that we've got some usages of Ex (note I know some of these are default props/initial state - just sharing for context):
If this is the right method to use (not 100% sure here since I'm not super familiar with new expensify code) then we should probably make sure it's used everywhere properly so that as more people contribute and see instances of how to do cc @AndrewGable @roryabraham @marcaaron @tgolen to gut check me here 🙇 |
Triggered auto assignment to @trjExpensify ( |
Hmmm I can't think of any reason that we would want to auto-focus this form input only on touch devices ... so I'm not sure TL;DR I think that @rushatgabhane's proposal looks good 👍 One thing to be aware of that we've run into in the past...There can be bugs with the react-navigation screen transition animation related to If (and only if) that ends up being something we need to do here, we should also be aware of some iOS safari quirks. Basically, iOS Safari really doesn't like websites using programatically triggered events to open the software keyboard. However, paradoxically, it does natively support the |
Triggered auto assignment to @roryabraham ( |
Created the job to apply here @rushatgabhane 👍 |
In src/components/IOUConfirmationList.js |
Thanks for the heads up. I just got a macbook, will test for it.
|
Accepted the proposal on Upwork and assigned you the issue, @rushatgabhane. 👍 |
PR was merged and deployed to staging yesterday. |
@trjExpensify, @rushatgabhane, @roryabraham it looks like no one is assigned to work on this job. |
@rushatgabhane completed this job and it was deployed to staging 6 days ago |
@trjExpensify Can we confirm that @rushatgabhane was paid for this issue then close it out? |
Yep, paid and closed out! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Keyboard should come up and auto focused to the "What's it for?"
Actual Result:
Keyboard is not focused to the "What's it for box?" box and user has to manually tap on it to write.
Workaround:
User has to manually tap the text box.
Platform:
Where is this issue occurring?
Version Number: 1.0.80-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Upwork Issue URL: https://www.upwork.com/jobs/~0100cc108c7250028f
View all open jobs on Upwork
From @joekaufmanexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1626898032104700
The text was updated successfully, but these errors were encountered: