Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook Request Step up to setupWithdrawalAccount #3689

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Conversation

NikkiWines
Copy link
Contributor

@NikkiWines NikkiWines commented Jun 18, 2021

cc: @marcaaron

Details

Hooks up the Requestor Step to our API so that submitting the form actually moves the user through to the next step of setting up their bank account

Fixed Issues

Fixes (partially) https://github.com/Expensify/Expensify/issues/167762#event-4911211124

Tests/QA

Non-OnFido Route

  1. Log into Expensify.cash
  2. Navigate to /bank-account/ and click Log Into Your Bank
  3. Follow the instructions from this SO to add an OPEN bank account
  4. Confirm you can get to the Requestor Step and that after submitting that step you are routed to the Beneficial Owners step.

OnFido Route

  1. Log into Expensify.cash
  2. Navigate to /bank-account/ and click Log Into Your Bank
  3. Follow the instructions from this SO to add an VERIFYING bank account
  4. Confirm you can get to the Requestor Step and that after submitting that step you are routed to the OnFido view.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-06-22 at 9 44 46 AM

Mobile Web

Desktop

iOS

Android

@NikkiWines NikkiWines self-assigned this Jun 18, 2021
@NikkiWines NikkiWines marked this pull request as ready for review June 22, 2021 16:53
@NikkiWines NikkiWines requested a review from a team as a code owner June 22, 2021 16:53
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team June 22, 2021 16:54
@NikkiWines
Copy link
Contributor Author

Currently trying to figure out why I get stuck in an endless loop when following the SO steps for adding a verifying BBA. Can't get past the requestor step, even though all of the data seems to be getting sent across correctly and entering the same values on E.com gets me to the OnFido stage without issue.

Screen Shot 2021-06-22 at 10 02 39 AM

Screen Shot 2021-06-22 at 10 08 33 AM

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just spotted a few small style things + question.

src/pages/ReimbursementAccount/RequestorStep.js Outdated Show resolved Hide resolved
src/pages/ReimbursementAccount/RequestorStep.js Outdated Show resolved Hide resolved
src/pages/ReimbursementAccount/RequestorStep.js Outdated Show resolved Hide resolved
@NikkiWines
Copy link
Contributor Author

updated!

@marcaaron
Copy link
Contributor

@NikkiWines Gonna :shipit: this since it seems to be working really well!
@thienlnam feel free to leave a review after it's merged if you spot anything we missed.

@marcaaron marcaaron merged commit 2c831b0 into main Jun 22, 2021
@marcaaron marcaaron deleted the nikki-requestor-api branch June 22, 2021 20:02
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@marcaaron
Copy link
Contributor

Throwing an InternalQA on here. But I'm not too sure if this can be QA'd at all while the secure server endpoint is pointing at production. Since this entire flow is behind a beta I don't think we need to worry about staging QA and can E2E test once everything is ready.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@NikkiWines Hello! not sure if we're able to test this PR. I'm unable to access the /bank-account URL, it just redirects me to the main page.

@NikkiWines
Copy link
Contributor Author

@isagoico this one is marked InternalQA, but actually (as marc mentioned above) we're actually going to be testing this everything goes live. You're good to check it off

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants