-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook Request Step up to setupWithdrawalAccount #3689
Conversation
Currently trying to figure out why I get stuck in an endless loop when following the SO steps for adding a verifying BBA. Can't get past the requestor step, even though all of the data seems to be getting sent across correctly and entering the same values on E.com gets me to the OnFido stage without issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just spotted a few small style things + question.
minor typos and style fixes
updated! |
@NikkiWines Gonna this since it seems to be working really well! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Throwing an InternalQA on here. But I'm not too sure if this can be QA'd at all while the secure server endpoint is pointing at production. Since this entire flow is behind a beta I don't think we need to worry about staging QA and can E2E test once everything is ready. |
🚀 Deployed to staging in version: 1.0.73-4🚀
|
@NikkiWines Hello! not sure if we're able to test this PR. I'm unable to access the /bank-account URL, it just redirects me to the main page. |
🚀 Deployed to production in version: 1.0.74-0🚀
|
cc: @marcaaron
Details
Hooks up the Requestor Step to our API so that submitting the form actually moves the user through to the next step of setting up their bank account
Fixed Issues
Fixes (partially) https://github.com/Expensify/Expensify/issues/167762#event-4911211124
Tests/QA
Non-OnFido Route
Log Into Your Bank
Beneficial Owners
step.OnFido Route
Log Into Your Bank
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android