Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] fix popover for native devices #3684

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 18, 2021

Follow up changes for #3635 (comment)
@roryabraham Please review.

Details

Fixed Issues

Fixes GH_LINK

Test | QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

menu-issue.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner June 18, 2021 20:24
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 18, 2021 20:24
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this follow-up @parasharrajat. Works for me on iOS 👍

@MonilBhavsar MonilBhavsar merged commit 0abd6ea into Expensify:main Jun 21, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.72-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants