You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new UX around setting a password during account signup.
Giving feedback to the user before submission on:
password complexity requirements
passwords matching
To get to this page:
trigger password reset
make sure you're logged out
navigate to here: http://localhost:8080/setpassword/[USERID]/[RESETCODE]
make sure you have credentials.login key set to your email address in local storage
Try to break the form by different combinations e.g. put in an invalid password, then replicate that in the next box. Then make the first password valid and see if the red hint turns green. And see if the passwords match error disappears.
You shouldn't be able to submit the form if the passwords don't match or the password doesn't meet the complexity requirements.
The hint should only turn red if an invalid password is entered and the focus leaves the input. After this condition has been met it should give real time feedback if this requirement is met or not.
The hint should turn green when a valid password is entered.
The passwords should match error should only show if the confirm box input loses focus while the passwords don't match. After this condition has been met it should give real time feedback if this requirement is met or not.
Testing submission:
When pressing the Set Password button:
If you use an invalid password or they don't match the set password button shouldn't do anything.
If you use an expired code the Validated code is likely expired error should shot.
If you used a password that meets the complexity then you should be logged into the app and your password will have been set/changed
Nice, this is looking pretty good! After you correctly fulfilled the password requirements at 0:11 of your video, I think the hint text below the input should not be red any more:
Then at 0:25 of the video, I would think that the Passwords must match error message would remain there until the passwords finally do match up - right now you have it so that the error goes away when you focus back into the field, but the error technically still remains.
I have made it so the match error only appears after the user has onblurred once on the confirm box with some input in there. The error will disappear and appear based on the passwords matching after that.
The hint text of the enter a password box now turns green once the password requirements are met.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Create a new UX around setting a password during account signup.
Giving feedback to the user before submission on:
password complexity requirements
passwords matching
Fixed Issues
Fixes #1517
QA Steps
To get to this page:
trigger password reset
make sure you're logged out
navigate to here: http://localhost:8080/setpassword/[USERID]/[RESETCODE]
make sure you have credentials.login key set to your email address in local storage
Then follow the video:
https://user-images.githubusercontent.com/47184118/120825774-a23f1c80-c551-11eb-9614-a5cf2f00414e.mp4
Testing the form
Try to break the form by different combinations e.g. put in an invalid password, then replicate that in the next box. Then make the first password valid and see if the red hint turns green. And see if the passwords match error disappears.
Testing submission:
When pressing the Set Password button:
If you use an invalid password or they don't match the set password button shouldn't do anything.
If you use an expired code the Validated code is likely expired error should shot.
If you used a password that meets the complexity then you should be logged into the app and your password will have been set/changed
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android