[No QA] Add check for isUsingExpensifyCard #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
changed the title
nickmurray47
approved these changes
Jun 22, 2021
Comment on lines
+204
to
+206
| if (isFromPublicDomain) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
why do public domains get excluded here?
There was a problem hiding this comment.
AFAIK only users with private domains as their primary login are eligible for the Expensify card. So, if they are on a public domain we don't need to know if they are using the Expensify card already since we'll show them alternative marketing copy that instructs them update their login first.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jun 25, 2021
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds check to see if the user already has the Expensify card provisioned on one of their domains.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/167543
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android