Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #3720

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Update CONTRIBUTING.md #3720

merged 1 commit into from
Jun 22, 2021

Conversation

mallenexpensify
Copy link
Contributor

Details

Update to clarify that a contributor needs to fix the issue in order to earn the bonus for reporting it.

Fixed Issues

No GH issue, Slack discussion here

Tests

None

QA Steps

Review https://github.com/Expensify/Expensify.cash/blob/main/CONTRIBUTING.md#user-content-proposing-a-job-that-expensify-hasnt-postedand ensure that "6. Before starting your PR to solve the bug or enhancement that you are proposing, please add a comment on your issue with a solution proposal." has been updated

@mallenexpensify mallenexpensify requested a review from a team as a code owner June 22, 2021 17:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from Jag96 and removed request for a team June 22, 2021 17:39
@Jag96
Copy link
Contributor

Jag96 commented Jun 22, 2021

Looks good, @mallenexpensify can you add I have read the CLA Document and I hereby sign the CLA as a comment so the CLA assistant passes?

@mallenexpensify
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Jag96 Jag96 merged commit 0b5862d into main Jun 22, 2021
@Jag96 Jag96 deleted the mallenexpensify-patch-1 branch June 22, 2021 22:40
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants