Send the sequenceNumber when deleting a report comment #3734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When making a call to the API to delete a report comment, we were not sending the
sequenceNumber
. On the API front, if nosequenceNumber
is provided, we default to-1
. ThePusher
event that would be sent when a comment gets deleted on one device would have asequenceNumber
of-1
, hence the comment could not be found or deleted.Fixed Issues
Fixes #3524
Tests
QA Steps
Same as tests
Tested On
Screenshots
Web & Desktop
Web (Safari) on the left, Desktop on the right