Create Validation Step #3587

ctkochan22 · 2021-06-15T07:09:48Z

@Luke9389 @marcaaron
cc @nkuoch @NikkiWines

Details

This is the Validation Step.

It takes in a form, once submitted will validate the bank account
Successfully closes the modal if amounts are correct
Tells users if input is invalid or incorrect

Also the Verifying Step

Show gif and tells users that we are verifying the BA's info

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/166921

Tests/QA Steps

Add a bank account, via the cash url: /bank-account. Use the Stack Overflow and follow the instructions for the "PENDING" state.

Verify that you see the form
Input non numeric answers and verify that it tells you "Invalid Amounts"
Input incorrect answers
Input correct Validation amounts. And verify that you get a success growl and modal is closed.
- You may need to run a query SELECT validateCode FROM bankAccounts WHERE bankAccountID={insert id};

For testing the verifying state, just add a bank account with whatever information. It should require manual verification from ops, in which it will be in the verifying state. Verify that the gif is there and copy tells you that.

Tested On

Screenshots

E.g. Validation Form

E.g. User exceeded max attempts to validate bank account (8 times)

E.g. Verifying state

Web

Mobile Web

Desktop

iOS

Android

github-actions · 2021-06-15T07:10:08Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

ctkochan22 · 2021-06-15T07:10:45Z

This is not ready to be reviewed yet @Luke9389 . I'll let you know!

ctkochan22 · 2021-06-15T07:52:58Z

Validation Forms Display:

Get form up
Get form submission to hit ValidateBankaccount in Web-Expensify
Validate the forms input
Style the forms
Display error messages for invalid input
Display error for max attempts reached
Take in a bank accountID
Build out logic to either show validation or verification

Verifying Gif Display:

Display gif

Wierdness:

After submitting and hitting the web-expensify api, it will no longer load the bank account and it craps out. I'm thinking it may be due to the state of the bank account

ctkochan22 · 2021-06-17T17:20:38Z

I have read the CLA Document and I hereby sign the CLA

marcaaron

This looks pretty great overall! Most of my comments are minor or just style callout stuff that you've probably not got to yet, but figured i'd mention anyway.

marcaaron · 2021-06-18T20:36:59Z

src/libs/actions/BankAccounts.js

-                // @TODO Not sure if we need to do this since for NewDot none of the accounts are pre-existing ones
-                currentStep = '';
-            }
+            failedValidationAttemptsName = CONST.NVP.FAILED_BANK_ACCOUNT_VALIDATIONS_PREFACE + bankAccountID;


NAB, I think this can be

const failedValidationAttemptsName = ...

since the other usage is in the same scope. Unless we do something like this...

return promiseAllSettled(...); }) .then(() => { ... });

Which is a pattern we use sometimes when chaining promises.

src/libs/actions/BankAccounts.js

src/pages/ReimbursementAccount/ValidationStep.js

shawnborton · 2021-06-22T01:23:37Z

Yes, that's perfect! Less is more!

ctkochan22 · 2021-06-22T01:37:21Z

@Luke9389 @marcaaron Ready for review!

marcaaron

Looks pretty great! Just caught a few small things like typos and nabs, but other than that 💯

Gonna test things out a bit and report back soon.

src/CONST.js

marcaaron · 2021-06-22T02:06:43Z

src/languages/en.js

+        buttonText: 'Finish Setup',
+        maxAttemptError: 'Validation for this bank account has been disabled due to too many incorrect attempts. Please contact us.',
+        description: 'A day or two after you add your account to Expensify we send three (3) transactions to your account. They have a merchant line like "Expensify, Inc. Validation"',
+        desriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51',


missing c in descriptionCTA

src/languages/es.js

marcaaron · 2021-06-22T02:18:35Z

src/pages/ReimbursementAccount/ValidationStep.js

+        if (amount1 && amount2 && amount3) {
+            const validateCode = [amount1, amount2, amount3].join(',');
+
+            // Make a call to bankAccounts


Seems like maybe this thought wasn't finished. Should we say which command or that we are calling the API? Maybe don't really need the comment at all.

src/pages/ReimbursementAccount/ValidationStep.js

marcaaron · 2021-06-22T02:54:19Z

Oh yeah also I'm not 100% sure how to get a bank account to the validation step with a PENDING state. But we can maybe test this once the whole flow is tied together. It'd be cool to update the clitools.sh script so it can more easily test some of these flows on dev.

marcaaron · 2021-06-22T02:57:54Z

Actually scratch that I figured it out. Was putting the wrong name in for the RequestorStep

marcaaron · 2021-06-22T03:01:35Z

Nice one. Tests perfectly!

One other small design tweak that we can figure out later but the error message is indented a little too far and could maybe be positioned under the 3 amounts instead of above. Looks great otherwise!

ctkochan22 · 2021-06-22T07:57:07Z

Updated

Luke9389

Yup! this looks good to me too. 👍

NikkiWines

👍

OSBotify · 2021-06-22T18:04:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-06-25T18:48:05Z

🚀 Deployed to staging in version: 1.0.73-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2021-06-25T22:10:32Z

@ctkochan22 Hello! not sure if we're able to test this PR. I'm unable to access the /bank-account URL, it just redirects me to the main page.

ctkochan22 · 2021-06-25T22:12:46Z

@marcaaron

ctkochan22 · 2021-06-25T22:14:36Z

Its behind a beta. You can check this off, we'll be testing this this again in the future with other PRs

OSBotify · 2021-06-29T18:59:11Z

🚀 Deployed to production in version: 1.0.74-0🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ctkochan22 added 6 commits June 14, 2021 21:27

Add header and make sure things are loading

cbbb536

get props and state

68d9829

get methods talking

3bbb98b

Add amound 2 and 3 and concatoate them

ebcc2e4

Add a call to WebAPI

af09ae8

remove debugging logs

ea09cfa

ctkochan22 self-assigned this Jun 15, 2021

ctkochan22 requested a review from a team as a code owner June 15, 2021 07:09

MelvinBot requested review from Luke9389 and removed request for a team June 15, 2021 07:10

export validate method

94ef391

Base automatically changed from marcaaron-setupWithdrawlAccount to main June 15, 2021 18:46

ctkochan22 added 9 commits June 16, 2021 11:52

Validate amounts

0bb78c3

Add clarification

37433a4

Merge branch 'main' into ckt_validationStep

adb440f

grab failed reimbursement

c0fd259

Pull bankaccountID first

4af47ae

Nest all validation in PENDING

794a1ae

Add images

fb6458a

fix image url

1fab732

merge master

a4b0c47

ctkochan22 added 3 commits June 17, 2021 13:26

Start getting all the copy lined up

1ac0380

Fix error

b1ff46b

dismiss modal upon success

6b4a465

ctkochan22 requested a review from marcaaron June 18, 2021 20:06

marcaaron reviewed Jun 18, 2021

View reviewed changes

ctkochan22 added 2 commits June 21, 2021 15:26

Update copy and add red text

4bf2b81

travis style

da55c9b

marcaaron requested changes Jun 22, 2021

View reviewed changes

fix final review

adaf7fb

Merge and fix conflicts

1bed83b

Luke9389 previously approved these changes Jun 22, 2021

View reviewed changes

marcaaron previously approved these changes Jun 22, 2021

View reviewed changes

fix conflicts

e0cecca

marcaaron dismissed stale reviews from Luke9389 and themself via e0cecca June 22, 2021 17:33

marcaaron approved these changes Jun 22, 2021

View reviewed changes

Luke9389 approved these changes Jun 22, 2021

View reviewed changes

NikkiWines approved these changes Jun 22, 2021

View reviewed changes

NikkiWines merged commit 318ffa0 into main Jun 22, 2021

NikkiWines deleted the ckt_validationStep branch June 22, 2021 18:04

This was referenced Jun 22, 2021

Deploy Checklist: Expensify.cash 2021-06-15 #3593

Closed

Deploy Checklist: Expensify.cash 2021-06-25 #3759

Closed

robertjchen mentioned this pull request Feb 8, 2023

App crash on entering test amount on Test transaction page #14847

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Validation Step #3587

Create Validation Step #3587

ctkochan22 commented Jun 15, 2021 •

edited

Loading

github-actions bot commented Jun 15, 2021 •

edited

Loading

ctkochan22 commented Jun 15, 2021

ctkochan22 commented Jun 15, 2021 •

edited

Loading

ctkochan22 commented Jun 17, 2021

marcaaron left a comment

marcaaron Jun 18, 2021

shawnborton commented Jun 22, 2021

ctkochan22 commented Jun 22, 2021

marcaaron left a comment

marcaaron Jun 22, 2021

marcaaron Jun 22, 2021

marcaaron commented Jun 22, 2021

marcaaron commented Jun 22, 2021

marcaaron commented Jun 22, 2021

ctkochan22 commented Jun 22, 2021

Luke9389 left a comment

NikkiWines left a comment

OSBotify commented Jun 22, 2021

OSBotify commented Jun 25, 2021

isagoico commented Jun 25, 2021

ctkochan22 commented Jun 25, 2021

ctkochan22 commented Jun 25, 2021

OSBotify commented Jun 29, 2021

Create Validation Step #3587

Create Validation Step #3587

Conversation

ctkochan22 commented Jun 15, 2021 • edited Loading

Details

Fixed Issues

Tests/QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

github-actions bot commented Jun 15, 2021 • edited Loading

ctkochan22 commented Jun 15, 2021

ctkochan22 commented Jun 15, 2021 • edited Loading

ctkochan22 commented Jun 17, 2021

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Jun 18, 2021

Choose a reason for hiding this comment

shawnborton commented Jun 22, 2021

ctkochan22 commented Jun 22, 2021

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Jun 22, 2021

Choose a reason for hiding this comment

marcaaron Jun 22, 2021

Choose a reason for hiding this comment

marcaaron commented Jun 22, 2021

marcaaron commented Jun 22, 2021

marcaaron commented Jun 22, 2021

ctkochan22 commented Jun 22, 2021

Luke9389 left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 22, 2021

OSBotify commented Jun 25, 2021

isagoico commented Jun 25, 2021

ctkochan22 commented Jun 25, 2021

ctkochan22 commented Jun 25, 2021

OSBotify commented Jun 29, 2021

ctkochan22 commented Jun 15, 2021 •

edited

Loading

github-actions bot commented Jun 15, 2021 •

edited

Loading

ctkochan22 commented Jun 15, 2021 •

edited

Loading