Payments - Unable to change PayPal account in Setting, green button always enabled.

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Click on aviator
4. Go to Settings- Payments
5. Change your PayPal account

Expected Result:

Able to change PayPal account

Actual Result:

Unable to change PayPal account in Setting, green button always enabled.

Workaround:

User has to change paypal account in e.com

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number: 1.0.69-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5115632_Screen_Recording_20210616-073859_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rushatgabhane]

Platform : Windows, Chrome.
I followed the steps and added new PayPal username.

The green button got disabled.
And it stayed disabled, even after I came back to it.

I'm unable to change PayPal username though.

[rushatgabhane]

Proposal

In PaymentPage.js
TextInput has a prop editable which will be made true always.

This is what I think the expected behavior of button should be.

• Disabled on empty username.
• Enabled after typing a username.
• Disabled after successfully adding a username.
• Button is enabled again if I change the username.

Modify the isDisabled prop of Button in PaymentPage.js to get this behaviour.

Thoughts on if this is what you think expected behaviour of Button should be?

[marcaaron]

Yes there is definitely some kind of regression here. If I had to guess I'd say it's related to the changes here -> https://github.com/Expensify/Expensify.cash/pull/3391/files

@jasperhuangg can you look into this for us?

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

@trjExpensify let's hold to see what @jasperhuangg says before creating an External issue for this ?

[trjExpensify]

Yep! 👍

[isagoico]

Issue reproducible today during KI retests.

[trjExpensify]

👋 @jasperhuangg any update on this? #3609 (comment)

[isagoico]

Issue reproducible during KI retests.

[jasperhuangg]

Hey guys! So sorry, I've completely been missing these notifications for whatever reason. I'll look into this first thing tomorrow.

[isagoico]

Issue reproducible during KI retests.

[trjExpensify]

PR is up, just waiting on being deployed to staging.

[isagoico]

Issue not reproducible during KI retests. Looks like this one was fixed, closing it out.