Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload locales to fix native crash #3749

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jun 25, 2021

Details

I'm not sure why it was only an issue on native, or why it was not reproducible on a dev build, but this seems to fix the crash.

Fixed Issues

$ #3606

Tests

  1. Run npm i -g ios-deploy
  2. Plug your phone into your computer (I was testing on a physical device - it may be reproducible on a sim, but I'm not sure).
  3. Run npm run ios --configuration Release --device "Target Device Name"
  4. Go to Settings -> Preferences and toggle the language picker. The app should not crash and the language should switch in the app.

QA Steps

Go to Settings -> Preferences and toggle the language picker. The app should not crash and the language should switch in the app.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image
image

Mobile Web

Desktop

iOS

RPReplay_Final1624579404.MP4

Android

@roryabraham roryabraham requested a review from jasperhuangg June 25, 2021 00:05
@roryabraham roryabraham self-assigned this Jun 25, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 25, 2021 00:05
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from pecanoro and removed request for a team June 25, 2021 00:05
@mountiny mountiny self-requested a review June 25, 2021 00:34
@roryabraham roryabraham merged commit 20312de into main Jun 25, 2021
@roryabraham roryabraham deleted the Rory-FixLanguagePicker branch June 25, 2021 00:40
github-actions bot pushed a commit that referenced this pull request Jun 25, 2021
Preload locales to fix native crash

(cherry picked from commit 20312de)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants