-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload locales to fix native crash #3749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
francoisl
approved these changes
Jun 25, 2021
robertjchen
approved these changes
Jun 25, 2021
mountiny
approved these changes
Jun 25, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
Preload locales to fix native crash (cherry picked from commit 20312de)
🚀 Cherry-picked to staging in version: 1.0.73-3🚀
|
72 tasks
🚀 Deployed to production in version: 1.0.73-3🚀
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
22 tasks
This was referenced Jul 7, 2021
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I'm not sure why it was only an issue on native, or why it was not reproducible on a dev build, but this seems to fix the crash.
Fixed Issues
$ #3606
Tests
npm i -g ios-deploy
npm run ios --configuration Release --device "Target Device Name"
Settings
->Preferences
and toggle the language picker. The app should not crash and the language should switch in the app.QA Steps
Go to
Settings
->Preferences
and toggle the language picker. The app should not crash and the language should switch in the app.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
RPReplay_Final1624579404.MP4
Android