Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Other currency is highlighted instead of the first after clearing search #35396

Closed
2 of 6 tasks
kbecciv opened this issue Jan 30, 2024 · 7 comments
Closed
2 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jan 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.33-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4251352
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

  1. Go to 1:1 DM.
  2. Click + > Request money.
  3. Click Currency.
  4. Enter search term that will return results (search "au).
  5. Move the selection with keyboard to the middle.
  6. Clear the search term.

Expected Result:

The first currency in the list will be highlighted.

Actual Result:

The selection is not with the first currency, but the selection still follows the last selection during search.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360840_1706618185518.20240130_160949.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Jan 30, 2024

We think that this bug might be related to #vip-bills
CC @davidcardoza

Copy link

melvin-bot bot commented Jan 30, 2024

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Jan 30, 2024

We think that this bug might be related to #vip-bills
CC @davidcardoza

@pecanoro
Copy link
Contributor

The bug is a little bit niche, so we might be able to remove the blocker label, but I am going to find the PR that caused it

@mkhutornyi
Copy link
Contributor

mkhutornyi commented Jan 30, 2024

Dupe of #35374
This is fixed in #35386 (v1.4.33-4)

@pecanoro
Copy link
Contributor

Not exactly a duplicate but it's the same cause so I am going to close this one since we are reverting the PR to fix the other blocker.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants