Fix highlighted user in new chat page is covered by referral view #35129

bernhardoj · 2024-01-25T06:01:28Z

Details

When we scroll down the list with a keyboard, the focused/highlighted user is covered by the referral view because we scroll to the wrong location.

Fixed Issues

$ #34112
PROPOSAL: #34112 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open new chat page
Scroll down the list with the keyboard arrow down > 10 times
Verify the list keeps scrolling to the bottom and that the focused user/option is not covered by the referral view (should be around the middle)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-25.at.13.55.03.mov

Android: mWeb Chrome

Screen.Recording.2024-01-25.at.13.53.29.mov

iOS: Native

Screen.Recording.2024-01-25.at.13.46.37.mov

iOS: mWeb Safari

Screen.Recording.2024-01-25.at.13.48.33.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-25.at.13.44.26.mov

MacOS: Desktop

Screen.Recording.2024-01-25.at.13.45.53.mov

melvin-bot · 2024-01-25T06:01:34Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-01-25T06:04:00Z

src/components/SelectionList/BaseSelectionList.tsx

-            }
-
-            listRef.current.scrollToLocation({sectionIndex: adjustedSectionIndex, itemIndex, animated, viewOffset: variables.contentHeaderHeight});
+            listRef.current.scrollToLocation({sectionIndex, itemIndex, animated, viewOffset: variables.contentHeaderHeight});


Even though the issue happens on OptionsSelector, SelectionList applies the same logic, so I removed it here too. Here is a video showing the scroll still works fine.

Screen.Recording.2024-01-25.at.13.45.17.mov

c3024 · 2024-01-26T10:16:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

scrollAndroid.mp4

Android: mWeb Chrome

scrollAndroidChrome.mp4

iOS: Native

scrolliOS.mp4

iOS: mWeb Safari

scrolliOSSafari.mp4

MacOS: Chrome / Safari

scrollChrome.mp4

MacOS: Desktop

scrollDesktop.mp4

c3024

LGTM

dangrous

Looks good!

OSBotify · 2024-01-29T16:45:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:26:06Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

pecanoro · 2024-01-30T13:32:20Z

I think this PR caused this regression here: #35396

c3024 · 2024-01-30T13:46:11Z

I think this PR caused this regression here: #35396

Screen.Recording.2024-01-30.at.7.14.54.PM.mov

Does not appear to be reproducible on latest main. This PR must not have caused it.

pecanoro · 2024-01-30T13:57:37Z

Yes, it was this PR, but this PR has been reverted already #35386 😄

c3024 · 2024-01-30T14:17:33Z

But that reverted #34485 not this 🤔

pecanoro · 2024-01-30T14:28:51Z

Ahh you are right, I didn't read properly, that's my bad, sorry!

dangrous · 2024-01-30T14:41:23Z

To confirm, I think we're all set here?

c3024 · 2024-01-30T18:36:44Z

Yep we're all set here

OSBotify · 2024-01-31T02:32:57Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

remove adjusting section index

2fde605

bernhardoj requested a review from a team as a code owner January 25, 2024 06:01

melvin-bot bot requested review from c3024 and removed request for a team January 25, 2024 06:01

bernhardoj commented Jan 25, 2024

View reviewed changes

c3024 approved these changes Jan 28, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous January 28, 2024 12:41

Merge branch 'main' into fix/34112-wrong-scroll-location

a9c3fbe

dangrous approved these changes Jan 29, 2024

View reviewed changes

dangrous merged commit 19f542a into Expensify:main Jan 29, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

melvin-bot bot mentioned this pull request Jan 31, 2024

[HOLD for payment 2024-02-07] [$500] Search - Focused account hidden by "Star a chat, get $250." when navigating with an arrow #34112

Closed

6 tasks

Pujan92 mentioned this pull request Feb 28, 2024

[WIP] Clean up BaseOptionsSelector #37353

Closed

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix highlighted user in new chat page is covered by referral view #35129

Fix highlighted user in new chat page is covered by referral view #35129

bernhardoj commented Jan 25, 2024

melvin-bot bot commented Jan 25, 2024

bernhardoj Jan 25, 2024

c3024 commented Jan 26, 2024 •

edited

Loading

c3024 left a comment

dangrous left a comment

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

pecanoro commented Jan 30, 2024

c3024 commented Jan 30, 2024

pecanoro commented Jan 30, 2024

c3024 commented Jan 30, 2024 •

edited

Loading

pecanoro commented Jan 30, 2024

dangrous commented Jan 30, 2024

c3024 commented Jan 30, 2024 •

edited

Loading

OSBotify commented Jan 31, 2024

Fix highlighted user in new chat page is covered by referral view #35129

Fix highlighted user in new chat page is covered by referral view #35129

Conversation

bernhardoj commented Jan 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 25, 2024

bernhardoj Jan 25, 2024

Choose a reason for hiding this comment

c3024 commented Jan 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

pecanoro commented Jan 30, 2024

c3024 commented Jan 30, 2024

pecanoro commented Jan 30, 2024

c3024 commented Jan 30, 2024 • edited Loading

pecanoro commented Jan 30, 2024

dangrous commented Jan 30, 2024

c3024 commented Jan 30, 2024 • edited Loading

OSBotify commented Jan 31, 2024

c3024 commented Jan 26, 2024 •

edited

Loading

c3024 commented Jan 30, 2024 •

edited

Loading

c3024 commented Jan 30, 2024 •

edited

Loading