[HOLD for payment 2024-02-14] [$500] Thread - Messages have a "Leave thread" option

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.33-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

1. Go to any chat.
2. Send a message.
3. Right-click on the message

Expected Result:

There should be no "Leave Thread" option if no thread exists.

Actual Result:

Messages without threads have a "Leave Thread" option.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360845_1706618382745.20240130_152420.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce5f6a37e8f18a12
• Upwork Job ID: 1752456002131746816
• Last Price Increase: 2024-02-01
• Automatic offers:
• Ollyws | Reviewer | 28134907
• paultsimura | Contributor | 28134908

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[sakluger]

I can't reproduce this, and I think it's probably not a deploy blocker even if it is reproduceable. Asking in QA Slack channel.

[sakluger]

Closing for now since I can't reproduce. I asked in #QA to reopen the issue if they find consistent reproduction steps.

[kbecciv]

QA team is able to reproduce it with above steps

Recording.5959.mp4

[melvin-bot]

Current assignee @sakluger is eligible for the Bug assigner, not assigning anyone new.

[sakluger]

This is on production so it's not a deploy blocker.

[sakluger]

Updated the original description to focus on the fact that message without threads have a "Leave Thread" option.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[srikarparsi]

Hey @paultsimura, your proposal looks good, we just need to remove the leaveThread option from the overflow menu for all comments. When do you think you can get a PR out by?

[paultsimura]

Thanks @srikarparsi, I can make it today

[melvin-bot]

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

Thanks. The PR is ready for review: #35573

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Remove the "Leave thread" option from the context menu #35573

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I paid out @paultsimura.

@Ollyws could you please accept the Upwork offer and also complete the BZ checklist? Thanks!

[Ollyws]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR:

This wasn't a bug just a design decision to remove the 'leave thread' option from the context menu.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

I don't think a regression test is helpful here as we were just removing an option from the context menu.

[sakluger]

Thanks! All paid out 🙌