[$500] Tag - Extra padding above Recent section in Tag list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.33-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has categories and tags, each has more than 8 items in the list.
• There are recent list in Category and Tag.

1. Go to workspace chat.
2. Open manual request page.
3. Enter amount > Next > Show more.
4. Open Category and Tag list.

Expected Result:

In Tag list, there will be no extra padding above Recent, just like the Category list.

Actual Result:

There is extra padding above Recent in Tag list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6361193_1706637788623.20240130_234328.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c2250ecc51e6cc7
• Upwork Job ID: 1752408936209432576
• Last Price Increase: 2024-01-30

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[francoisl]

Here's production (left) vs. staging (right) side by side, it's a pretty minor gap so I'm thinking we can fix it later.

[ghost]

I think, since it is a such a minor issue. We should fix it right away. So, can we do it ?

[francoisl]

Yeah I'll remove the blocker label for now and open this to contribution ideas to fix. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c2250ecc51e6cc7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra padding above Recent section in Tag list

What is the root cause of that problem?

In tag picker we set the top margin as 5.

App/src/components/TagPicker/index.js

Lines 61 to 64 in fc523dc

	<OptionsSelector
	contentContainerStyles={[{paddingBottom: StyleUtils.getSafeAreaMargins(insets).marginBottom}]}
	optionHoveredStyle={styles.hoveredComponentBG}
	sectionHeaderStyle={styles.mt5}

What changes do you think we should make in order to solve the problem?

Set the top margin to lower value or remove it.

What alternative solutions did you explore? (Optional)

N/A

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra padding above Recent section in Tag list

What is the root cause of that problem?

Caused by #32470
Previous check of isEmpty is now changed to selectedOptions the array itself will be truthy although empty

App/src/libs/OptionsListUtils.ts

Lines 1089 to 1090 in a44e804

	if (selectedOptions) {
	const selectedTagOptions = selectedOptions.map((option) => {

What changes do you think we should make in order to solve the problem?

We should check it is empty as checking its length

    if (selectedOptions?.length >0) {

What alternative solutions did you explore? (Optional)

[aimane-chnaif]

Since this was deploy blocker, there should be offending PR

[FitseTLT]

@aimane-chnaif Found the offending pr. Updated proposal

[FitseTLT]

@francoisl @danieldoglas @DylanDylann The root cause is found and we can fix it ASAP. WDYT

[DylanDylann]

@FitseTLT's proposal looks good to me
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @danieldoglas is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[danieldoglas]

Wait, if this was caused by a recent PR (less than 7 days of the regression period), the original author of that PR needs to fix it.

[danieldoglas]

cc @kubabutkiewicz can you please take a look into this, since it's still part of the regression period?

[DylanDylann]

@danieldoglas Thanks for pointing out that. I will note that for next issues

[situchan]

I tagged original author/reviewer already in #24921 (comment)

[kubabutkiewicz]

Will create PR shortly

[kubabutkiewicz]

PR ready: #35541

[DylanDylann]

@danieldoglas The author of the offending PR fixed this issue. Let's close this one