[HOLD for payment 2024-02-15] [$500] Wallet - Input in Activate card page has BNP and also allows device keypad

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35303

Action Performed:

1. Log in with account that has Expensify card (virtual) (applausetester@applause.expensifail.com
   ).
2. Go to Settings > Wallet.
3. Tap Expensify card.
4. Tap Activate physical card.
   Note that

Expected Result:

The page will either show BNP and disable device keypad input, or disable BNP and allow device keypad input

Actual Result:

The page shows BNP and the digit input also allows device keypad at the same time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362455_1706713671288.Screen_Recording_20240131_221648_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ec1c0f677740061
• Upwork Job ID: 1752714526879559680
• Last Price Increase: 2024-01-31
• Automatic offers:
• getusha | Reviewer | 28137110
• bernhardoj | Contributor | 28137111

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ec1c0f677740061

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[lanitochka17]

We think that this bug might be related to #wave.
CC @dylanexpensify

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A keyboard is shown alongside with the big number pad on the activate card page.

What is the root cause of that problem?

We didn't disable the keyboard to show. We pass a isDisableKeyboard props to the magic code input,

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.js

Lines 144 to 145 in d0e8e2a

	<MagicCodeInput
	isDisableKeyboard

but we didn't disable the keyboard when isDisableKeyboard is true.

What changes do you think we should make in order to solve the problem?

We need to disable the keyboard when isDisableKeyboard is true.

App/src/components/MagicCodeInput.tsx

Lines 368 to 369 in d0e8e2a

	<TextInput
	onLayout={(e) => {

disableKeyboard={isDisableKeyboard}

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BNP is shown in the activate card page

What is the root cause of that problem?

we disable keyboard in the activate card apge

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.js

Line 145 in 9208c95

isDisableKeyboard

What changes do you think we should make in order to solve the problem?

remove the prev prop as we do in other MagicCodeInput instances so that we have a consistent view

[getusha]

@bernhardoj looks like we don't have this issue on SignIn page is there any reason behind that? and looks like the prop was intentionally avoided to pass as disableKeyboard 4bf0243#diff-ecae0b82a8a72087e4f45a15da40053c9b9addf7e830c5ba2975f24956bb9eaaR142

[bernhardoj]

Sign in page doesn't have a BNP, so it's different. From the commit you gave, you can see that we previously passed the props here 4bf0243#diff-913e8c5633c454fc244676c3b1bb09d85b256cc5b65763a9b02b58c58fab31bbR297

But somehow it's gone now and probably because of some conflict with the TS PR?

[getusha]

You're right i got confused.

[getusha]

@bernhardoj's proposal looks good to me and works well.
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pecanoro]

Sounds good, assigning @bernhardoj!

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @getusha

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix keyboard shows on activate card page #35675

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

Payment summary:

@bernhardoj requires payment automatic offer (Contributor) paid$500
@getusha requires payment automatic offer (Reviewer) paid $500.