-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Preferences page #35606
Comments
Triggered auto assignment to @garrettmknight ( |
Hey, I'm Kuba from Software Mansion and I will work on this issue. The draft of the PR is already prepared, but we are waiting for the #35603 to be merged. |
Assigned you! |
I'll take the BZ on the main from @garrettmknight, given I'm closer to this. |
👋 Can we get marketing copy for the subheader intro on these pages where there's filler right now, please? Thanks! TRJ suggestion for consideration: TRJ suggestion for consideration: TRJ's suggestion: |
Triggered auto assignment to @NickTooker ( |
Putting this on |
@trjExpensify Let me know your thoughts. |
No strong reason. I just thought "experience" sounded nicer as they kinda' fell into that for me. I.e your theme, LHN sorting logic, language. Though I guess there's a marketing preference toggle in there, so maybe it doesn't quite wholly fit. Not passionate!
Cool, I think this one is now pretty long -- especially for mobile. Perhaps we just cut the close account part? I.e Enable two-factor authentication to keep your account safe.
Nice edit. Maybe we avoid the "refer/referral" repetition though and switch the first word to "invite"? I.e Invite members to Expensify by sharing your personal QR code or referral link. |
>Enable two-factor authentication to keep your account safe. >Invite members to Expensify by sharing your personal QR code or referral link. |
Yes, I'm not sure what else we would say here. I am fine with: >Configure your account's test preferences. |
Do it!
Ah shit yeah, forgot about that one. These are only displayed on staging, so maybe the below? 🤔 Test preferences |
Good catch! Agreed with your copy suggestion then. |
Righteous—mocks are all up to date. |
Cool, @kosmydel.. the mock in the OP of this issue has been updated for |
Here are all the Spanish translations for those:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
On staging |
Okay, so payment time I think here. @s77rt you were the PR reviewer on this, right? Are these regression pings above bogus? |
@trjExpensify Yes I reviewed the PR. There were 2 bugs #36444 and #35672 (comment). Can you assign me here? |
Alright, I'm not going to reduce for those minor bugs given we rolled in a couple of other pages to that PR. So I'll send you an offer for $500 for the C+ review. Does that work for you? |
@trjExpensify Sounds great! Thank you! |
Perfect, offer sent! |
Accepted! |
Settled up! |
Coming from tracking issue for this initiative.
Using the Figma final mocks, please update the Account Settings Preferences page in the new ideal navigation layout to look like this:
For help with anything unclear, please, post in wave8 room.
Please tag design team for a review on the PR before merging.
cc @trjExpensify @dannymcclain
The text was updated successfully, but these errors were encountered: