Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Preferences page #35606

Closed
mountiny opened this issue Feb 1, 2024 · 28 comments
Closed
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the Account Settings Preferences page in the new ideal navigation layout to look like this:

image

For help with anything unclear, please, post in wave8 room.

Please tag design team for a review on the PR before merging.

cc @trjExpensify @dannymcclain

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@kosmydel
Copy link
Contributor

kosmydel commented Feb 2, 2024

Hey, I'm Kuba from Software Mansion and I will work on this issue.

The draft of the PR is already prepared, but we are waiting for the #35603 to be merged.

@trjExpensify
Copy link
Contributor

Assigned you!

@mountiny mountiny self-assigned this Feb 2, 2024
@trjExpensify
Copy link
Contributor

I'll take the BZ on the main from @garrettmknight, given I'm closer to this.

@trjExpensify
Copy link
Contributor

👋 Can we get marketing copy for the subheader intro on these pages where there's filler right now, please? Thanks!

Preferences
image

TRJ suggestion for consideration:
Customise your Expensify experience.

Security
image

TRJ suggestion for consideration:
Enable 2FA to keep your account extra safe, or close your account if you no longer need it.

Share code
image

TRJ's suggestion:
Invite people to Expensify by sharing a personalised QR code or link.

@trjExpensify trjExpensify added the Waiting for copy User facing verbiage needs polishing label Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

Triggered auto assignment to @NickTooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 5, 2024
@trjExpensify trjExpensify removed the Weekly KSv2 label Feb 5, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 5, 2024
@trjExpensify
Copy link
Contributor

Putting this on daily as we have PRs in the works.

@NickTooker
Copy link

NickTooker commented Feb 5, 2024

Customize your Expensify account.
Is there a reason your suggestions was to use the word "experience"? I'm not sure we use that widely elsewhere so I think account may be better.

Enable two-factor authentication to keep your account safe, or close your account if you no longer need it.
Let's keep 'two factor authentication' consistent vs 2FA - let's remove extra, it doesn't add to the sentence here IMO.

Refer members to Expensify by sharing your personal QR code or referral link.
I'm using Refer, members, and referral here to be consistent with language we've used elsewhere - please let me know if you disagree.

@trjExpensify Let me know your thoughts.

@trjExpensify
Copy link
Contributor

Customize your Expensify account.
Is there a reason your suggestions was to use the word "experience"? I'm not sure we use that widely elsewhere so I think account may be better.

No strong reason. I just thought "experience" sounded nicer as they kinda' fell into that for me. I.e your theme, LHN sorting logic, language. Though I guess there's a marketing preference toggle in there, so maybe it doesn't quite wholly fit. Not passionate!

Enable two-factor authentication to keep your account safe, or close your account if you no longer need it.
Let's keep 'two factor authentication' consistent vs 2FA - let's remove extra, it doesn't add to the sentence here IMO.

Cool, I think this one is now pretty long -- especially for mobile. Perhaps we just cut the close account part? I.e

Enable two-factor authentication to keep your account safe.

Refer members to Expensify by sharing your personal QR code or referral link.
I'm using Refer, members, and referral here to be consistent with language we've used elsewhere - please let me know if you disagree.

Nice edit. Maybe we avoid the "refer/referral" repetition though and switch the first word to "invite"? I.e

Invite members to Expensify by sharing your personal QR code or referral link.

@NickTooker
Copy link

NickTooker commented Feb 5, 2024

>Enable two-factor authentication to keep your account safe.
Perfect. Close account button speaks for itself.

>Invite members to Expensify by sharing your personal QR code or referral link.
Good catch on refer/referral - this looks great to me.

@dannymcclain
Copy link
Contributor

Love this! Should I update the mocks?! :excited:

Also can we get one more for Test preferences? Obviously this one is not as important, but still. Maybe something simple like Configure your account's test preferences?

CleanShot 2024-02-05 at 14 46 04@2x

@NickTooker
Copy link

Yes, I'm not sure what else we would say here. I am fine with:

>Configure your account's test preferences.

@trjExpensify
Copy link
Contributor

Should I update the mocks?! :excited:

Do it!

Also can we get one more for Test preferences? Obviously this one is not as important, but still. Maybe something simple like Configure your account's test preferences?

Ah shit yeah, forgot about that one. These are only displayed on staging, so maybe the below? 🤔

Test preferences
Settings to help debug and test the app on staging.

@NickTooker
Copy link

NickTooker commented Feb 5, 2024

These are only displayed on staging

Good catch! Agreed with your copy suggestion then.

@dannymcclain
Copy link
Contributor

Righteous—mocks are all up to date.

@trjExpensify
Copy link
Contributor

Cool, @kosmydel.. the mock in the OP of this issue has been updated for Preferences. 👍

@trjExpensify
Copy link
Contributor

Here are all the Spanish translations for those:

Preferencias de la aplicación
Personaliza tu cuenta de Expensify.

Preferencias para tests
Ajustes para ayudar a depurar y probar la aplicación en “staging”.

Opciones de seguridad
Activa la autenticación de dos factores para mantener tu cuenta segura.

Tu código
Invita a miembros a Expensify compartiendo tu código QR personal o enlace de invitación.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 8, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 13, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@mountiny mountiny changed the title [HOLD App#35603] [Wave8] [Account Settings] Update Preferences page [Wave8] [Account Settings] Update Preferences page Feb 14, 2024
@mountiny
Copy link
Contributor Author

On staging

@trjExpensify trjExpensify changed the title [Wave8] [Account Settings] Update Preferences page [Awaiting Payment 20th Feb[Wave8] [Account Settings] Update Preferences page Feb 16, 2024
@trjExpensify trjExpensify changed the title [Awaiting Payment 20th Feb[Wave8] [Account Settings] Update Preferences page [Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Preferences page Feb 16, 2024
@trjExpensify
Copy link
Contributor

Okay, so payment time I think here. @s77rt you were the PR reviewer on this, right? Are these regression pings above bogus?

@s77rt
Copy link
Contributor

s77rt commented Feb 21, 2024

@trjExpensify Yes I reviewed the PR. There were 2 bugs #36444 and #35672 (comment).

Can you assign me here?

@trjExpensify
Copy link
Contributor

Alright, I'm not going to reduce for those minor bugs given we rolled in a couple of other pages to that PR. So I'll send you an offer for $500 for the C+ review. Does that work for you?

@s77rt
Copy link
Contributor

s77rt commented Feb 21, 2024

@trjExpensify Sounds great! Thank you!

@trjExpensify
Copy link
Contributor

Perfect, offer sent!

@s77rt
Copy link
Contributor

s77rt commented Feb 21, 2024

Accepted!

@trjExpensify
Copy link
Contributor

Settled up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants