Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave8] [Account Settings] Update Security page #35607

Closed
mountiny opened this issue Feb 1, 2024 · 10 comments
Closed

[Wave8] [Account Settings] Update Security page #35607

mountiny opened this issue Feb 1, 2024 · 10 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the Account Settings Security page in the new ideal navigation layout to look like this:

image

For help with anything unclear, please, post in wave8 room.

Please tag design team for a review on the PR before merging.

cc @trjExpensify @dannymcclain

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@mountiny
Copy link
Contributor Author

mountiny commented Feb 2, 2024

Will be handled by SWM

@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I will work on this issue!

@trjExpensify
Copy link
Contributor

Updated the mock in the OP of this issue to replace the placeholder subheader copy!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 8, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@MitchExpensify
Copy link
Contributor

Can we take this off hold @mountiny ?

Copy link

melvin-bot bot commented Feb 13, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@mountiny mountiny changed the title [HOLD App#35603] [Wave8] [Account Settings] Update Security page [Wave8] [Account Settings] Update Security page Feb 14, 2024
@mountiny
Copy link
Contributor Author

On staging

@trjExpensify
Copy link
Contributor

Consolidating on this issue for payment: #35606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants