-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sections - Cards on the right hand page are left aligned instead of centered #35688
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @bondydaa ( |
We think that this bug might be related to #vip-vsp |
hmm @Expensify/design anyone familiar with recent changes for these types of elements? Even if not can you help confirm how they should look? I'm guessing centered aligned? |
if I had to guess it might be from this big PR https://github.com/Expensify/App/pull/33280/files#diff-701113bd02bdc9f8c671df93b0a5a0d2dadb520ae378674c8cfa956d1eb2daff but I only say that b/c I see it touches a lot of styles (I haven't looked through all PRs from the deploy checklist either). |
I think this is by design not a bug |
i could see that too 😁 do you have a GH or anything where we made that decision? |
Correct, not a bug! This is part of the #ideal-nav design doc |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The cards on the right hand page are centered
Actual Result:
The cards on the right hand page are left aligned
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6365111_1706895548818.20240203_013630.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: