[HOLD for payment 2024-03-20] [$500] duplicate update available notifications

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: y
Reproducible in production?: not sure
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707325061283629

Action Performed:

1. Leave desktop app running
2. Wait for multiple staging app deploys
3. Go back online

Expected Result:

Only one "Update available" notification displays

Actual Result:

Multiple update notifications display

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b52a9d9f6e91e6ec
• Upwork Job ID: 1755982205531607040
• Last Price Increase: 2024-02-23
• Automatic offers:
• DylanDylann | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[slafortune]

@arosiclair should a C+ be added to this for review or is it something you will handle completely?

[arosiclair]

@arosiclair should a C+ be added to this for review or is it something you will handle completely?

Yeah this will be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b52a9d9f6e91e6ec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[DylanDylann]

@arosiclair This issue relates to the notification system. So I think It should be handled on the BE side

[arosiclair]

The update available notifications are client side and should be fixable with tags. Not all notification issues are from the backend.

[melvin-bot]

@arosiclair, @slafortune, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[DylanDylann]

Waiting proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[slafortune]

Checking with expert contributors

[melvin-bot]

@arosiclair @slafortune @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[arosiclair]

Still waiting on proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Piotrfj]

Hi, Im Piotr from Callstack, I will start investigating this issue.

[ShridharGoel]

@Piotrfj If you are occupied with other tasks, is it possible to make this external ? Just wanted to know if that works.

…

On Thu, Feb 29, 2024, 4:01 PM Piotrfj ***@***.***> wrote: Work on this issue is on hold due to higher priority task - regressions on BaseOptionsSelector. Will come back to this probably on monday — Reply to this email directly, view it on GitHub <#36081 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPLJHHTZYWWANTI7GUFB6DYV4BPLAVCNFSM6AAAAABC6RMWB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQHA2DIMBVGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[arosiclair]

Yeah if you are already occupied @Piotrfj, let's go with another contributor. @ShridharGoel's proposal is already on the money so I'll assign them

[melvin-bot]

📣 @ShridharGoel You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[ShridharGoel]

Link to pull request: #37595

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show only one update available notification at a time #37595

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  https://github.com/Expensify/Expensify/issues/380893

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open the Expensify App.
2. Wait for a new deployment.
3. Check that "Update Available" notification is showing.
4. Wait for more deployments.
5. Only one update notification should show.

Do we agree 👍 or 👎

[slafortune]

@ShridharGoel offer sent here
@DylanDylann Paid ✅

[slafortune]

All paid ✔️