Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #36071][$500] Chat - Chat is partially scrolled down when editing message #36254

Closed
2 of 6 tasks
lanitochka17 opened this issue Feb 9, 2024 · 15 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Request money
  3. Create a manual request with receipt from any user
  4. In 1:1 DM, send two messages
  5. Right click on the latest message > Edit message
  6. Click close button
  7. Right click on the latest message > Edit message

Expected Result:

The chat is completely scrolled down to reveal the edit composer

Actual Result:

The chat is partially scrolled down to reveal the edit composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6373750_1707493266226.bandicam_2024-02-09_23-09-00-265.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa6de1a654051f75
  • Upwork Job ID: 1756009647894945792
  • Last Price Increase: 2024-02-09
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@tgolen tgolen added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. labels Feb 9, 2024
@melvin-bot melvin-bot bot changed the title Chat - Chat is partially scrolled down when editing message [$500] Chat - Chat is partially scrolled down when editing message Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01aa6de1a654051f75

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@tgolen
Copy link
Contributor

tgolen commented Feb 9, 2024

I'm going to see if I can get some help to look into this. If this is related to LiveMarkdown, then we should stop looking into it further because all those bugs are being addressed separately in #36071.

@thienlnam
Copy link
Contributor

thienlnam commented Feb 9, 2024

https://github.com/Expensify/App/assets/30609178/101ddb18-4d55-483d-916c-276e35145f7c
I wasn't able to reproduce after reverting the Live markdown PR, so going to mark this off and hold onto it for tracking

@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@thienlnam
Copy link
Contributor

Not a current bug, but being worked on as part of #36071

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2024
Copy link

melvin-bot bot commented Feb 23, 2024

@thienlnam this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 23, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Feb 26, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@thienlnam thienlnam changed the title [$500] Chat - Chat is partially scrolled down when editing message [HOLD #36071][$500] Chat - Chat is partially scrolled down when editing message Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2024
@thienlnam
Copy link
Contributor

Not a current bug, but being worked on as part of #36071

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@BartoszGrajdek
Copy link
Contributor

I believe this is not happening anymore @thienlnam can we get someone to test it on staging & close this issue in case of it being fixed?

@kavimuru
Copy link

kavimuru commented Apr 3, 2024

@thienlnam Unable to reproduce.

bandicam.2024-04-03.22-28-57-409.mp4

@thienlnam
Copy link
Contributor

Sweet - thanks!

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants