Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-02-08 #36168

Closed
77 tasks done
github-actions bot opened this issue Feb 8, 2024 · 19 comments
Closed
77 tasks done

Deploy Checklist: New Expensify 2024-02-08 #36168

github-actions bot opened this issue Feb 8, 2024 · 19 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Release Version: 1.4.39-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kbecciv kbecciv added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 8, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.39-0 🚀

@dangrous
Copy link
Contributor

dangrous commented Feb 8, 2024

Closed #36174 - dupe of #33114 and reproducible on prod

@marcaaron
Copy link
Contributor

Checked off #36183 as it is niche (Android mWeb while offline) and doesn't affect app usability.

@Julesssss
Copy link
Contributor

Checked off #36218 as a blocker as it's a very minor problem.

@kbecciv
Copy link

kbecciv commented Feb 9, 2024

Regression is 2% left

#34135 is pending validation in Desktop
#35137 is failing #36175
#35470 is pending validation in Desktop and Android
#35744 is pending validation in Desktop
#35837 is pending validation in Desktop and Web
#35875 is pending validation in Android and mWeb

Deploy Blockers:
#36173
#36175
#36180
#36185
#36199
#36200
#36201
#36202
#36217
#36227

@kbecciv
Copy link

kbecciv commented Feb 9, 2024

Regression is completed!

#34135 is failing #36184, closed - not a bug, checking Off
#35137 is failing #36175
#35744 is failing #36215
#35837 is failing #36253 in Desktop and Web
#35875 is failing #36230 in Android app, and #35436 in mWeb/safari, left a comment - #35875 (comment)

Deploy Blockers:
#36173
#36175
#36180
#36185
#36199
#36200
#36201
#36202
#36217
#36227
#36230
#36246
#36253
#36254
#36260
#36263
#36265
#36268
#36270
#36272

@neil-marcellini
Copy link
Contributor

Checking off #36272 because it's very minor, and I rather release the new feature first.

@thienlnam
Copy link
Contributor

Checked off all the ones that were related to live markdown

@marcaaron
Copy link
Contributor

Blocker was removed for #36246

@marcaaron
Copy link
Contributor

Looks like #36201 was closed

@marcaaron
Copy link
Contributor

Fixed #36265 with a CP

@marcaaron
Copy link
Contributor

Fixed #36230 with a CP

@marcaaron
Copy link
Contributor

Removing blocker on #36202 as you would need to be on the policy expense chat beta to experience it.

@kbecciv
Copy link

kbecciv commented Feb 11, 2024

CP #36287 is failing #36306 and #36307

Deploy Blockers:
#36175
#36270
#36306
#36307

@Beamanator
Copy link
Contributor

Created PR #36329 to hopefully fix 3 blockers - CPing to staging soon, then will test

@Beamanator
Copy link
Contributor

Checking off #36270 because the fix is on staging & tests well

@Beamanator
Copy link
Contributor

Checking off #36287 for fixing #36175

And checking off #36329 for fixing #36306 and #36307

@Beamanator
Copy link
Contributor

Github is only having a few copilot issues, let's ship!

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants