-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mWeb - Settings – Banner in About, Preference and Security is partly visible when open it Offline #36183
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @stitesExpensify ( |
I don't think this has anything to do with offline. It just seems like the new design we implemented here #35662 can someone confirm @mountiny @shawnborton ? |
Oh I think "partly visible" means we are missing the animation section. Got it now. Yes, reproduced on Android web. Given that this only affects offline and very specific to this platform I'm not sure we need to make this a deploy blocker, but seems possibly related to that PR linked above. |
Triggered auto assignment to @garrettmknight ( |
Interesting, thanks, I think this can be handled by SWM as a follow up @kosmydel @filip-solecki |
Sure, we will work on this! |
On main |
@filip-solecki any ETA on starting to work on this one? |
Shouldn't it be closed as we moved illustrations on those pages to Card component? (as @mountiny mentioned above) |
Ah, good call. Closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Banner in About, Preference and Security is fully visible when open it Offline
Actual Result:
Banner in About, Preference and Security is partly visible when open it Offline
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6372680_1707429741877.Banners.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: