Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Settings – Banner in About, Preference and Security is partly visible when open it Offline #36183

Closed
1 of 6 tasks
kbecciv opened this issue Feb 8, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login and go Offline
  3. Navigate to Settings
  4. Click on About
  5. Scroll to view the banner
  6. Click on Preferences
  7. Scroll to view the banner
  8. Click on Security
  9. Scroll to view the banner

Expected Result:

Banner in About, Preference and Security is fully visible when open it Offline

Actual Result:

Banner in About, Preference and Security is partly visible when open it Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372680_1707429741877.Banners.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv kbecciv changed the title Settings – Banner in About, Preference and Security is partly visible when open it Offline mWeb - Settings – Banner in About, Preference and Security is partly visible when open it Offline Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@marcaaron
Copy link
Contributor

I don't think this has anything to do with offline. It just seems like the new design we implemented here #35662

can someone confirm @mountiny @shawnborton ?

@marcaaron
Copy link
Contributor

Oh I think "partly visible" means we are missing the animation section. Got it now. Yes, reproduced on Android web.

Given that this only affects offline and very specific to this platform I'm not sure we need to make this a deploy blocker, but seems possibly related to that PR linked above.

@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 9, 2024
@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny
Copy link
Contributor

mountiny commented Feb 9, 2024

Interesting, thanks, I think this can be handled by SWM as a follow up @kosmydel @filip-solecki

@mountiny mountiny self-assigned this Feb 9, 2024
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Feb 9, 2024
@filip-solecki
Copy link
Contributor

Sure, we will work on this!

@mountiny
Copy link
Contributor

All of the images should be in the card now
image
so I feel like this hsould be not repro anymore

@mountiny
Copy link
Contributor

On main

@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2024
@garrettmknight
Copy link
Contributor

@filip-solecki any ETA on starting to work on this one?

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2024
@filip-solecki
Copy link
Contributor

Shouldn't it be closed as we moved illustrations on those pages to Card component? (as @mountiny mentioned above)

@garrettmknight
Copy link
Contributor

Ah, good call. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants