Update account settings/profile #35662

filip-solecki · 2024-02-02T13:42:14Z

Details

Fixed Issues

$ #35603
PROPOSAL:
N/A

Tests

Verify that no errors appear in the JS console

Log in to the app
Open Account Settings
Choose "Profile" if not selected
Check if everything looks and works fine

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

![Simulator Screenshot - iPhone 15 Plus - 2024-02-02 at 15 35 49](https://github.com/Expensify/App/assets/153545991/547f52e9-9df6-4956-91b1-aefc7be5c194)

MacOS: Chrome / Safari

MacOS: Desktop

src/pages/settings/Profile/ProfilePage.js

melvin-bot · 2024-02-02T15:04:52Z

@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2024-02-02T15:21:27Z

If this requires C+ review, I can help

kosmydel · 2024-02-02T15:25:15Z

If this requires C+ review, I can help

cc @mountiny, as this PR blocks other design changes

mountiny · 2024-02-02T18:58:12Z

Sorry for the ping @situchan go ahead please

mountiny · 2024-02-02T18:59:25Z

Lets please make sure everything works as expected too @situchan

situchan · 2024-02-05T10:50:39Z

please merge main

mountiny · 2024-02-05T11:20:51Z

@situchan Hello! Whats your ETA once this is synced up with main? thank you!

situchan · 2024-02-05T11:22:58Z

@situchan Hello! Whats your ETA once this is synced up with main? thank you!

going to review immediately.

@filip-solecki please also fix typescript checks

filip-solecki · 2024-02-07T11:53:00Z

@situchan rebuild should help

mountiny · 2024-02-07T11:53:02Z

@situchan feel free to proceed with the checklist, the failing jobs do not require you to wait

situchan · 2024-02-07T12:01:15Z

@mountiny can this be out of scope as part of back navigation issue?

New dup page is opened instead of going back

Screen.Recording.2024-02-07.at.5.59.23.PM.mov

situchan · 2024-02-07T12:07:29Z

src/pages/settings/Profile/PersonalDetails/AddressPage.js

@@ -122,7 +122,7 @@ function AddressPage({privatePersonalDetails, route}) {
            <HeaderWithBackButton
                title={translate('privatePersonalDetails.address')}
                shouldShowBackButton
-                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PERSONAL_DETAILS)}
+                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PROFILE)}


I think it's fine to skip param. Simply call Navigation.goBack()
This is consistent with DisplayName page

I also tested this flow:

deep link to https://dev.new.expensify.com:8082/settings/profile/address

Press Back button

It correctly goes to Profile page

Agree it can be skipped. Profile page is now in central pane so it's always mounted under the RHP and we don't need to pass it as param for go back.

Yes, fixed in all places

situchan · 2024-02-07T12:25:12Z

src/libs/actions/PersonalDetails.ts

@@ -112,7 +112,7 @@ function updateLegalName(legalFirstName: string, legalLastName: string) {
        ],
    });

-    Navigation.goBack(ROUTES.SETTINGS_PERSONAL_DETAILS);
+    Navigation.goBack(ROUTES.SETTINGS_PROFILE);


Please update submit button case as well

situchan · 2024-02-07T12:28:52Z

@adamgrzybowski is this expected?

Screen.Recording.2024-02-07.at.6.27.25.PM.mov

The issue is that browser back button (go to home) and app back button (go to Settings) are inconsistent

adamgrzybowski · 2024-02-07T12:37:52Z

@situchan

The issue is that browser back button (go to home) and app back button (go to Settings) are inconsistent

They should have different functionality.

The go back in the browser is more a history navigation.
goBack in the RHP (Legal name in that case) should navigate in navigation tree: Legal name -> Profile

situchan

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

melvin-bot · 2024-02-07T12:44:03Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #36016.

situchan · 2024-02-07T12:44:42Z

@mountiny all yours

mountiny · 2024-02-07T18:22:12Z

Making a build for design team https://github.com/Expensify/App/actions/runs/7819398551

github-actions · 2024-02-07T21:42:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35662/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35662/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35662/NewExpensify.dmg	https://35662.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny

Thank you!

mountiny

Thanks

OSBotify · 2024-02-08T09:20:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-08T18:44:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-12T14:01:55Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

kosmydel and others added 6 commits February 1, 2024 15:46

refactor section styling

67a7d8c

new Profile page designs

ce7523d

Add title styles and spanish translation

e98f871

Apply styles to both sections

5acf846

Merge branch 'main' into update-account-settings/profile

d5e12f4

Fix fontSize and padding

b8b5976

SzymczakJ reviewed Feb 2, 2024

View reviewed changes

src/pages/settings/Profile/ProfilePage.js Show resolved Hide resolved

filip-solecki added 2 commits February 2, 2024 15:26

Make title bold

1160e20

Fix childrenStyles

e679d5d

kosmydel approved these changes Feb 2, 2024

View reviewed changes

filip-solecki marked this pull request as ready for review February 2, 2024 15:04

filip-solecki requested a review from a team as a code owner February 2, 2024 15:04

melvin-bot bot requested review from robertjchen and removed request for a team February 2, 2024 15:04

Merge branch 'main' into update-account-settings/profile

c006060

mountiny requested review from cubuspl42, mountiny and situchan and removed request for cubuspl42 February 2, 2024 18:57

mountiny assigned filip-solecki Feb 2, 2024

redesign preferences page

34fe83b

Merge branch 'Expensify:main' into update-account-settings/profile

9e124d3

situchan reviewed Feb 7, 2024

View reviewed changes

Fix goBack

bc774da

situchan reviewed Feb 7, 2024

View reviewed changes

Update submit navigation

99ba948

situchan approved these changes Feb 7, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Feb 7, 2024

[Payment due Feb 22] Payment issue for E/App PR#35662 #36016

Closed

mountiny added the Ready To Build label Feb 7, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' into update-account-settings/profile

3f7cd92

robertjchen removed their request for review February 7, 2024 21:37

mountiny previously approved these changes Feb 8, 2024

View reviewed changes

Merge branch 'main' into update-account-settings/profile

c576325

filip-solecki dismissed mountiny’s stale review via c576325 February 8, 2024 05:59

mountiny approved these changes Feb 8, 2024

View reviewed changes

mountiny merged commit 19ca917 into Expensify:main Feb 8, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 8, 2024

Deploy Checklist: New Expensify 2024-02-08 #36168

Closed

77 tasks

marcaaron mentioned this pull request Feb 9, 2024

mWeb - Settings – Banner in About, Preference and Security is partly visible when open it Offline #36183

Closed

6 tasks

c3024 mentioned this pull request Feb 20, 2024

[HOLD for payment 2024-03-13] [$1000] Android - Personal Details - User can open both Address and Date of birth when quick tap on them #32753

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update account settings/profile #35662

Update account settings/profile #35662

filip-solecki commented Feb 2, 2024 •

edited

Loading

melvin-bot bot commented Feb 2, 2024

situchan commented Feb 2, 2024

kosmydel commented Feb 2, 2024

mountiny commented Feb 2, 2024

mountiny commented Feb 2, 2024

situchan commented Feb 5, 2024

mountiny commented Feb 5, 2024

situchan commented Feb 5, 2024

filip-solecki commented Feb 7, 2024

mountiny commented Feb 7, 2024

situchan commented Feb 7, 2024

situchan Feb 7, 2024 •

edited

Loading

adamgrzybowski Feb 7, 2024

filip-solecki Feb 7, 2024

situchan Feb 7, 2024

filip-solecki Feb 7, 2024

situchan commented Feb 7, 2024

adamgrzybowski commented Feb 7, 2024

situchan left a comment

melvin-bot bot commented Feb 7, 2024

situchan commented Feb 7, 2024

mountiny commented Feb 7, 2024

This comment has been minimized.

github-actions bot commented Feb 7, 2024

mountiny left a comment

mountiny left a comment

OSBotify commented Feb 8, 2024

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

Update account settings/profile #35662

Update account settings/profile #35662

Conversation

filip-solecki commented Feb 2, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 2, 2024

situchan commented Feb 2, 2024

kosmydel commented Feb 2, 2024

mountiny commented Feb 2, 2024

mountiny commented Feb 2, 2024

situchan commented Feb 5, 2024

mountiny commented Feb 5, 2024

situchan commented Feb 5, 2024

filip-solecki commented Feb 7, 2024

mountiny commented Feb 7, 2024

situchan commented Feb 7, 2024

situchan Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

adamgrzybowski Feb 7, 2024

Choose a reason for hiding this comment

filip-solecki Feb 7, 2024

Choose a reason for hiding this comment

situchan Feb 7, 2024

Choose a reason for hiding this comment

filip-solecki Feb 7, 2024

Choose a reason for hiding this comment

situchan commented Feb 7, 2024

adamgrzybowski commented Feb 7, 2024

situchan left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Feb 7, 2024

situchan commented Feb 7, 2024

mountiny commented Feb 7, 2024

This comment has been minimized.

github-actions bot commented Feb 7, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 8, 2024

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

filip-solecki commented Feb 2, 2024 •

edited

Loading

situchan Feb 7, 2024 •

edited

Loading