[HOLD E/E #359760] [$500] No "Hold Request" and "Add a receipt" option on workspace expense report as Admin

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #35744
Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Create a new expense request on a collect policy
2. Submit the expense
3. Open the expense report
4. Right-click/long-press the expense preview
5. (if employee) Verify there is no Delete Request (if admin) Verify there is a Delete Request option
6. Press the expense preview to open the transaction thread
7. Press the three-dots button
8. (if employee) Verify there is no Delete Request and Add receipt (if admin) Verify there is a Delete Request and Add receipt option

Expected Result:

There should be Hold Request and Add a receipt option on Admins side

Actual Result:

No "Hold Request" and "Add a receipt" option on workspace expense report as Admin

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372780_1707437362871.Recording__2143.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c35580d297f84569
• Upwork Job ID: 1755778907181215744
• Last Price Increase: 2024-03-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c35580d297f84569

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[bernhardoj]

As the test step coming from my PR, I would like to clarify one thing. The delete request and add receipt option will be shown if the user is an admin AND the action/request owner, so this is not a bug.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[hoangzinh]

The delete request and add receipt option will be shown if the user is an admin AND the action/request owner, so this is not a bug.

@bernhardoj could you share where did we discuss about this behavior? Because I think the Admin should have permission to delete request option, shouldn't they?

[bernhardoj]

The action owner condition has existed for quite some time

App/src/libs/ReportUtils.ts

Line 1239 in 9463e22

if (isActionOwner) {

and I added the admin condition based on this comment

[hoangzinh]

Thank @bernhardoj. @MitchExpensify what do you think about our new expected behavior?

[marcaaron]

Create a new expense request on a collect policy

Gonna mark this as a non-blocker as people on Collect policies are not actually using these flows yet

[melvin-bot]

@hoangzinh, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[youssef-lr]

I've added a fix here since I touched that logic in the PR 06f3d4d, this is aligned with what we have in OldDot

[trjExpensify]

So this will be fixed by #46931 in review, right?

[youssef-lr]

Yup!

[melvin-bot]

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

Not overdue, PR has been merged

[melvin-bot]

@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

@youssef-lr The PR #46931 has been deployed to Prod. Are we good to re-test this issue?

[melvin-bot]

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

it's been a while so we no longer have the three dots, but I see hold on this expense.

[kevinksullivan]

@hoangzinh original posting expired so here is a new one in upwork

https://www.upwork.com/jobs/~014ecea72e003c577c

lmk when you accept!

[hoangzinh]

It's an internal issue and I haven't reviewed the PR so no payment for me @kevinksullivan

[melvin-bot]

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

still looking for internal volunteer

[hoangzinh]

@kevinksullivan It appears that we're good to close this issue #36202 (comment). Arent' we? 🤔

[melvin-bot]

@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

Not overdue, I think we can close this issue

[trjExpensify]

#36202 (comment) - yep, closing.