[HOLD for payment 2024-03-05] [$250] 2 bottom banners for offline status are displayed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

1. Go to Workspace > Bank account.
2. Initiate the add BA flow until you reach the Personal info double check page.
3. Disable the internet connection.

Expected Result:

Only 1 bottom banner for offline status should be displayed.

Actual Result:

2 bottom banners for offline status are displayed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e92a84369a21d16
• Upwork Job ID: 1757589397607944192
• Last Price Increase: 2024-02-14
• Automatic offers:
• akinwale | Contributor | 0
• abzokhattab | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016e92a84369a21d16

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2 bottom banners for offline status are displayed

What is the root cause of that problem?

the offline message is shown twice because we have two ScreenWrapper instances

1. inside the PersonalInfo
2. inside the ConfirmationUBO

so whenever the network is offline, the offline indicator shows in each component causing it to be shown twice

What changes do you think we should make in order to solve the problem?

1. we can remove the ScreenWrapper inside the ConfirmationUBO and move the top padding styles.pt0 inside the underlying ScrollView styles
2. Or we can add shouldShowOfflineIndicator={false} inside the screen wrapper of theConfirmationUBO component which will disable the offline indicator

Additionally, we need to disable the confirm button in case the network is offline

            isDisabled={isOffline}

[mountiny]

This is minor design bug not a blocker

[mountiny]

cc @shubham1206agra too

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Upwork job price has been updated to $150

[MrMuzyk]

Double check spacing around submit button. If it works then I'm fine with such solution

[mountiny]

Yeah lets remove the second wrapper and fix any misalignments if that happens

[akinwale]

@abzokhattab Let's go with the solution to remove the second wrapper and check the layout and spacing according to #36458 (comment).

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

sorry for the ping @techievivek

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Payment for @akinwale will be handled here #22901 (comment)

[abzokhattab]

Just a kindly reminder for the payment of this issue @mountiny

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@akinwale, @johncschuster, @mountiny, @abzokhattab Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Payment has been issued to @abzokhattab via Upwork
Coming from @mountiny's comment here, it looks like payment for @akinwale will be handled in #22901 (comment)