[HOLD for payment 2024-03-07] [$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap settings icon
3. Tap workspaces
4. Tap on a Workspace which has default currency
5. Tap reimbursements
6. Tap connect bank account
7. Tap app back button
8. Again tap app back button

Expected Result:

Tapping on connect back account in reimbursement page, and tapping app back button, user must be able to navigate to LHN

Actual Result:

Tapping on connect back account in reimbursement page, and tapping app back button unable to navigate to LHN. User is directed to "connect bank account" & "workspaces" page repeatedly instead of LHN when tapping app back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378738_1707864984255.az_recorder_20240214_012516.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0fc2f48cc03bdf1
• Upwork Job ID: 1757590533941366784
• Last Price Increase: 2024-02-14
• Automatic offers:
• jjcoffee | Contributor | 0
• abzokhattab | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0fc2f48cc03bdf1

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tap connect BA in reimbursements & tap app back button unable to go LHN

What is the root cause of that problem?

the go-back behavior when we have the following dialog is not the same when we have USD currency set.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 471 in 9f060e6

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}

What changes do you think we should make in order to solve the problem?

we need to change the onBackButtonPress in the prev component to be the same as ContinueBankAccountSetup component :

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 486 to 489 in 9f060e6

	onBackButtonPress={() => {
	Navigation.goBack();
	}}
	/>

[ntdiary]

Hey, @trjExpensify, I'm OOO until Feb 18th, could you please reassign another c+? :)

[jjcoffee]

Happy to take this one over @trjExpensify 🙇

[trjExpensify]

We think that this bug might be related to #vip-vsp

This is likely ideal-nav related with goBack, so wave8 is more appropriate. CC: @adamgrzybowski @hayata-suenaga is this on the radar somewhere?

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hayata-suenaga]

This is likely ideal-nav related with goBack, so wave8 is more appropriate. CC: @adamgrzybowski @hayata-suenaga is this on the radar somewhere?

The fix for the back navigation was deployed to production. @adamgrzybowski could you check if this issue is related to the back navigation issue?

[trjExpensify]

Thanks!

[jjcoffee]

@abzokhattab's proposal LGTM! We appear to just be using goBack to navigate to the incorrect page here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 471 in 9f060e6

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}

So I don't think this is anything wrong with back navigation itself.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

@grgia awaiting your secondary review of the proposal please!

[hayata-suenaga]

So I don't think this is anything wrong with back navigation itself.

nice! I'll leave this to @grgia to select the proposal 🙇

[grgia]

All yours @abzokhattab

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

not overdue, assigned

[jjcoffee]

@abzokhattab Don't forget to let us know when we can expect a PR. Thanks!

[abzokhattab]

Should be ready today @jjcoffee thank you

[jjcoffee]

PR is up! I will review on Monday.

[trjExpensify]

Thanks, @jjcoffee! Over to you, @grgia. :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix reimbursement account page back navigation #37120

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Contributor)
• @abzokhattab requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav  #33280
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8] Ideal nav  #33280 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - massive PR so unavoidable to have a few mistakes
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Tap settings icon
2. Tap Workspaces
3. Tap on a workspace which has non-USD default currency
4. Tap reimbursements
5. Tap connect bank account
6. Tap app back button
7. Tap app back button again
8. Validate you navigate back to the settings page

Do we agree 👍 or 👎

[trjExpensify]

Thanks!

Payment summary as follows:

• $500 to @jjcoffee for the C+ review - paid
• $500 to @abzokhattab for the fix - paid

Going to hold off on the regression test, as we're changing that flow now, so we're in the process of updating with the new workspace editor.