-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure categories are decoded and displayed properly when added from workspace settings from newDot #36473
Comments
Triggered auto assignment to @sonialiap ( |
cc @luacmartins since you're working on wave8 simplified collect categories project |
@sonialiap this will be handled internally, feel free to unassign 😄 |
@MonilBhavsar take a look at #36622 it was created and closed yesterday it is related to ampersand inconsitently getting html encoded and decoded on category leading to a crash I reproduced it before I wrote my proposal but it was closed by |
Putting it on HOLD |
Still on HOLD |
@MonilBhavsar have U checked #36622 (comment) |
What are the next steps for this issue, @MonilBhavsar? If we put something on hold, let's reference the specific issue it's held on. A lot of the categories issues/PRs have merged, so it's unclear if this is unblocked. Thanks! CC: @luacmartins |
Held on #35710 as we can start adding new categories from newDot after that issue.
After the held issue is closed. We need to ensure we are decoding and storing categories in our DB. Most probably will need backend change for that |
Thanks for making the dependency clear! @luacmartins has a PR in review for the CreateCategoriesPage, so shouldn't be too long a hold now! |
Held issue is closed, taking it off hold and I'll take a look |
@MonilBhavsar where you at on this one? Is this issue still necessary? |
I'll get back to this early next week. This can be treated as polish item for the wave-collect |
Got back here and working on this! |
Dealing with some track tax issues, circling back |
Moving it to daily and wrapping it up! |
Discussing about the solution here https://expensify.slack.com/archives/C03TQ48KC/p1714480744709159?thread_ts=1707467669.800489&cid=C03TQ48KC |
We decided to do nothing
If user enters category in encoded format, we store and display it in encode format. |
Problem
Context: https://expensify.slack.com/archives/C03TQ48KC/p1707467669800489
Categories added from workspace settings in oldDot are stored in encoded format and we need to decode at the client side to display it properly in decoded format
Why it is important
To display and store categories properly and consistently across all layers of the App.
We have this bug in newDot where categories added in encoded format are not displayed correctly #34735 and we decided not to decode for categories added from oldDot.
Solution
When adding/importing categories from workspace settings in newDot, ensure category name is decoded and displayed properly throughout the application
The text was updated successfully, but these errors were encountered: