Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure categories are decoded and displayed properly when added from workspace settings from newDot #36473

Closed
MonilBhavsar opened this issue Feb 14, 2024 · 18 comments
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Feb 14, 2024

Problem

Context: https://expensify.slack.com/archives/C03TQ48KC/p1707467669800489
Categories added from workspace settings in oldDot are stored in encoded format and we need to decode at the client side to display it properly in decoded format

Why it is important

To display and store categories properly and consistently across all layers of the App.
We have this bug in newDot where categories added in encoded format are not displayed correctly #34735 and we decided not to decode for categories added from oldDot.

Solution

When adding/importing categories from workspace settings in newDot, ensure category name is decoded and displayed properly throughout the application

@MonilBhavsar MonilBhavsar self-assigned this Feb 14, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 NewFeature Something to build that is a new item. labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

@MonilBhavsar
Copy link
Contributor Author

cc @luacmartins since you're working on wave8 simplified collect categories project

@MonilBhavsar
Copy link
Contributor Author

@sonialiap this will be handled internally, feel free to unassign 😄

@FitseTLT
Copy link
Contributor

@MonilBhavsar take a look at #36622 it was created and closed yesterday it is related to ampersand inconsitently getting html encoded and decoded on category leading to a crash I reproduced it before I wrote my proposal but it was closed by Bug member due to inconsistency of reproduction of the issue.

@MonilBhavsar
Copy link
Contributor Author

Putting it on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Feb 22, 2024
@MonilBhavsar MonilBhavsar changed the title Ensure categories are decoded and displayed properly when added from workspace settings from newDot [HOLD Categories in wave8] Ensure categories are decoded and displayed properly when added from workspace settings from newDot Feb 22, 2024
@sonialiap sonialiap removed their assignment Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@MonilBhavsar
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@FitseTLT
Copy link
Contributor

FitseTLT commented Mar 4, 2024

@MonilBhavsar have U checked #36622 (comment)

@trjExpensify
Copy link
Contributor

What are the next steps for this issue, @MonilBhavsar? If we put something on hold, let's reference the specific issue it's held on. A lot of the categories issues/PRs have merged, so it's unclear if this is unblocked. Thanks! CC: @luacmartins

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@trjExpensify trjExpensify changed the title [HOLD Categories in wave8] Ensure categories are decoded and displayed properly when added from workspace settings from newDot [HOLD Categories in Wave Collect] Ensure categories are decoded and displayed properly when added from workspace settings from newDot Mar 5, 2024
@MonilBhavsar
Copy link
Contributor Author

Held on #35710 as we can start adding new categories from newDot after that issue.

What are the next steps for this issue

After the held issue is closed. We need to ensure we are decoding and storing categories in our DB. Most probably will need backend change for that

@MonilBhavsar MonilBhavsar changed the title [HOLD Categories in Wave Collect] Ensure categories are decoded and displayed properly when added from workspace settings from newDot [HOLD Categories in Wave Collect #35710] Ensure categories are decoded and displayed properly when added from workspace settings from newDot Mar 5, 2024
@trjExpensify
Copy link
Contributor

Thanks for making the dependency clear! @luacmartins has a PR in review for the CreateCategoriesPage, so shouldn't be too long a hold now!

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@MonilBhavsar
Copy link
Contributor Author

Held issue is closed, taking it off hold and I'll take a look

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@MonilBhavsar MonilBhavsar changed the title [HOLD Categories in Wave Collect #35710] Ensure categories are decoded and displayed properly when added from workspace settings from newDot Ensure categories are decoded and displayed properly when added from workspace settings from newDot Mar 15, 2024
@trjExpensify
Copy link
Contributor

@MonilBhavsar where you at on this one? Is this issue still necessary?

@MonilBhavsar
Copy link
Contributor Author

I'll get back to this early next week. This can be treated as polish item for the wave-collect

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@MonilBhavsar
Copy link
Contributor Author

Got back here and working on this!

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 9, 2024
@MonilBhavsar
Copy link
Contributor Author

Dealing with some track tax issues, circling back

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2024
@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Polish in [#whatsnext] #wave-collect Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Weekly KSv2 labels Apr 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
@MonilBhavsar
Copy link
Contributor Author

Moving it to daily and wrapping it up!

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@MonilBhavsar
Copy link
Contributor Author

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@MonilBhavsar
Copy link
Contributor Author

We decided to do nothing

Whatever the user typed is what we should store in the DB and the same thing is what they should see in the app (which is not the same thing as what we should output in HTML

If user enters category in encoded format, we store and display it in encode format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

4 participants