Ensure categories are decoded and displayed properly when added from workspace settings from newDot

[MonilBhavsar]

Problem

Context: https://expensify.slack.com/archives/C03TQ48KC/p1707467669800489
Categories added from workspace settings in oldDot are stored in encoded format and we need to decode at the client side to display it properly in decoded format

Why it is important

To display and store categories properly and consistently across all layers of the App.
We have this bug in newDot where categories added in encoded format are not displayed correctly #34735 and we decided not to decode for categories added from oldDot.

Solution

When adding/importing categories from workspace settings in newDot, ensure category name is decoded and displayed properly throughout the application

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MonilBhavsar]

cc @luacmartins since you're working on wave8 simplified collect categories project

[MonilBhavsar]

@sonialiap this will be handled internally, feel free to unassign 😄

[FitseTLT]

@MonilBhavsar take a look at #36622 it was created and closed yesterday it is related to ampersand inconsitently getting html encoded and decoded on category leading to a crash I reproduced it before I wrote my proposal but it was closed by Bug member due to inconsistency of reproduction of the issue.

[MonilBhavsar]

Putting it on HOLD

[MonilBhavsar]

Still on HOLD

[FitseTLT]

@MonilBhavsar have U checked #36622 (comment)

[trjExpensify]

What are the next steps for this issue, @MonilBhavsar? If we put something on hold, let's reference the specific issue it's held on. A lot of the categories issues/PRs have merged, so it's unclear if this is unblocked. Thanks! CC: @luacmartins

[MonilBhavsar]

Held on #35710 as we can start adding new categories from newDot after that issue.

What are the next steps for this issue

After the held issue is closed. We need to ensure we are decoding and storing categories in our DB. Most probably will need backend change for that

[trjExpensify]

Thanks for making the dependency clear! @luacmartins has a PR in review for the CreateCategoriesPage, so shouldn't be too long a hold now!

[MonilBhavsar]

Held issue is closed, taking it off hold and I'll take a look

[trjExpensify]

@MonilBhavsar where you at on this one? Is this issue still necessary?

[MonilBhavsar]

I'll get back to this early next week. This can be treated as polish item for the wave-collect

[MonilBhavsar]

Got back here and working on this!

[MonilBhavsar]

Dealing with some track tax issues, circling back

[MonilBhavsar]

Moving it to daily and wrapping it up!

[MonilBhavsar]

Discussing about the solution here https://expensify.slack.com/archives/C03TQ48KC/p1714480744709159?thread_ts=1707467669.800489&cid=C03TQ48KC

[MonilBhavsar]

We decided to do nothing

Whatever the user typed is what we should store in the DB and the same thing is what they should see in the app (which is not the same thing as what we should output in HTML

If user enters category in encoded format, we store and display it in encode format.