Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-14] [$500][Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action #35710

Closed
luacmartins opened this issue Feb 2, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement CreateWorkspaceCategoriesPage: full page implementation, onyx action from the Simplified Collect: Profile, Members, Categories design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ba488440a2f9a1b8
  • Upwork Job ID: 1755659204123680768
  • Last Price Increase: 2024-02-08
@luacmartins luacmartins added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Feb 2, 2024
@luacmartins luacmartins self-assigned this Feb 2, 2024
@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title CreateWorkspaceCategoriesPage: full page implementation, onyx action [Simplified Collect] [Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@ArekChr can you please comment here so I can assign you to the issue?

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action [Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@ArekChr
Copy link
Contributor

ArekChr commented Feb 5, 2024

Sure, please assign me @luacmartins

Copy link

melvin-bot bot commented Feb 8, 2024

@luacmartins, @ArekChr, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action [$500] [Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ba488440a2f9a1b8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@luacmartins luacmartins added Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2024
@greg-schroeder
Copy link
Contributor

Held

@melvin-bot melvin-bot bot removed the Overdue label Feb 22, 2024
@trjExpensify trjExpensify changed the title [HOLD for #35705] [$500][Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action [$500][Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action Feb 23, 2024
@trjExpensify
Copy link
Contributor

Removing the holds.

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@luacmartins
Copy link
Contributor Author

@ArekChr is still working through the other implementation issues.

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2024
@luacmartins
Copy link
Contributor Author

I'll start working on this one

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 5, 2024
@melvin-bot melvin-bot bot changed the title [$500][Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action [HOLD for payment 2024-03-14] [$500][Simplified Collect][Categories] CreateWorkspaceCategoriesPage: full page implementation, onyx action Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests
  • @ArekChr does not require payment (Contractor)

Copy link

melvin-bot bot commented Mar 7, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mananjadhav
Copy link
Collaborator

@greg-schroeder This will be ready for payout tomorrow. Could you update the payout summary when this is ready for payout?

Because this is a new feature there's no offending PR. But I think it makes sense we add a regression test with the Test steps from the PR.

@greg-schroeder
Copy link
Contributor

Yup @mananjadhav you can make a manual request for $500 for the reviewer role

@greg-schroeder
Copy link
Contributor

Filed regression test issue. I'm going to close this as there's no payment actually due from me, and you can make a manual request and review the comment above

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 14, 2024
@JmillsExpensify
Copy link

$500 approved for @mananjadhav based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

6 participants