Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment Due] [$250] [MEDIUM] Cancel payment - LHN preview for payment cancellation is not in the same format as payment #36704

Closed
6 tasks done
m-natarajan opened this issue Feb 16, 2024 · 74 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.42-1
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause team
Slack conversation:

Action Performed:

  1. [Member] Request money in workspace chat.
  2. [Admin} Pay elsewhere the request.
  3. [Member] Note that the LHN preview shows "Admin: paid $ elsewhere" format.
  4. [Admin] Cancel the payment.

Expected Result:

For Member, the LHN preview for payment cancellation will show "Admin: cancelled the $ payment" format.

Actual Result:

For Member, the LHN preview for payment cancellation shows "workspace cancelled the $ payment".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381973_1708095040651.20240216_215744.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0137ae4b0301cf5ea2
  • Upwork Job ID: 1758509319146360832
  • Last Price Increase: 2024-05-06
  • Automatic offers:
    • dukenv0307 | Contributor | 0
    • nkdengineer | Contributor | 0
Issue OwnerCurrent Issue Owner: @
@m-natarajan m-natarajan added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0137ae4b0301cf5ea2

Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@m-natarajan
Copy link
Author

@aimane-chnaif FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this might be related to #wave5-free-submitters
cc @dylanexpensify

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 19, 2024
@zanyrenney
Copy link
Contributor

I took a look -- the copy should match but I actually think its more wave 6 than wave 5 - posting there.

@zanyrenney
Copy link
Contributor

Copy link

melvin-bot bot commented Feb 19, 2024

@zanyrenney, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@zanyrenney
Copy link
Contributor

I just updated this 😓

@greg-schroeder greg-schroeder changed the title Cancel payment - LHN preview for payment cancellation is not in the same format as payment [MEDIUM] Cancel payment - LHN preview for payment cancellation is not in the same format as payment Feb 19, 2024
@zanyrenney
Copy link
Contributor

Updated to wave 6.

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@aimane-chnaif
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 26, 2024
@zanyrenney
Copy link
Contributor

what is the latest on it though @aimane-chnaif ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

@zanyrenney @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@aimane-chnaif
Copy link
Contributor

Should we make this External?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@zanyrenney, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@zanyrenney
Copy link
Contributor

Hmm not sure why this had the internal label, amending so it can be worked on.

Copy link

melvin-bot bot commented May 10, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@zanyrenney
Copy link
Contributor

ugh yikes the job is closed, going to manually recreate.

@zanyrenney
Copy link
Contributor

2024-05-10_12-51-17 @nkdengineer @dukenv0307 please accept job invites.

@GoodWork0903

This comment was marked as off-topic.

This comment was marked as off-topic.

@GoodWork0903

This comment was marked as off-topic.

Copy link

melvin-bot bot commented May 10, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@nkdengineer
Copy link
Contributor

@zanyrenney I believe the price should be $500 since the issue was created from a long time ago. Melvin updated the price incorrectly after the External label was reapplied for payments. Could you help to send the offer for the correct amount, thanks!
Screenshot 2024-05-11 at 1 45 58 AM

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels May 13, 2024
@zanyrenney
Copy link
Contributor

I'll add the bonus to make it up to the $500 @nkdengineer

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2024
@zanyrenney
Copy link
Contributor

zanyrenney commented May 16, 2024

please accept the job payout https://www.upwork.com/jobs/~0126c929f11bc84aa6

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@zanyrenney
Copy link
Contributor

have bumped @nkdengineer again to accept proposal for payout.

@melvin-bot melvin-bot bot removed the Overdue label May 20, 2024
@zanyrenney
Copy link
Contributor

@nkdengineer
Copy link
Contributor

@zanyrenney I applied to the job, thanks!

@zanyrenney
Copy link
Contributor

offer sent, please accept for payout.

@nkdengineer
Copy link
Contributor

@zanyrenney I accepted it!

@zanyrenney
Copy link
Contributor

paid @nkdengineer $250 via upwork.

@dukenv0307
Copy link
Contributor

@zanyrenney Could you release C+ payment for my offer too? (Amount should also be $500)

@zanyrenney
Copy link
Contributor

@dukenv0307 released, you had not accepted the offer before which was preventing the payout. 😅

@zanyrenney
Copy link
Contributor

**payment summary **

paid @dukenv0307 $500 via upwork
paid @nkdengineer $500 via upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Development

No branches or pull requests