Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate VideoPlayerPreview component files to TypeScript #36725

Closed
hayata-suenaga opened this issue Feb 16, 2024 · 38 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 16, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

File related to the VideoPlayerPreview component

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ee4768426d2275b1
  • Upwork Job ID: 1758559492550733824
  • Last Price Increase: 2024-02-16
  • Automatic offers:
    • ntdiary | Reviewer | 0
    • situchan | Contributor | 0
@hayata-suenaga hayata-suenaga added External Added to denote the issue can be worked on by a contributor Daily KSv2 Typescript Migration labels Feb 16, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ee4768426d2275b1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@ghost
Copy link

ghost commented Feb 16, 2024

Dibs

@MahmudjonToraqulov
Copy link
Contributor

Would like to work on it.

@rayane-djouah
Copy link
Contributor

dibs

@ZhenjaHorbach
Copy link
Contributor

I can work on it
And I don't have others TS issues assigned to me

@Koustubh-lapate
Copy link

I am Koustubh, a full stack developer. I’d like to work on this job.

@suneox
Copy link
Contributor

suneox commented Feb 17, 2024

I don't have any TS migration assigned so would like to work on this ticket, this ticket using VideoPlayerContexts so I can cover #36724 in this ticket

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@aneequeahmad
Copy link
Contributor

I would like to work on this issue. I'm not being assigned any TS related issues.

@kowczarz
Copy link
Contributor

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue.

@hkopser99
Copy link
Contributor

Hi @hayata-suenaga, I just completed my first TS migration for the Expensify project (approved PR here) and am ready to take on another if this is not yet assigned. Please let me know :)

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@kowczarz
Copy link
Contributor

Hey, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task.

@smelaa
Copy link
Contributor

smelaa commented Feb 20, 2024

Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue.

Copy link

melvin-bot bot commented Feb 20, 2024

📣 @smelaa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@hayata-suenaga hayata-suenaga assigned smelaa and unassigned kowczarz Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Mar 18, 2024
@grgia
Copy link
Contributor

grgia commented Mar 20, 2024

We only need one C+ for the PR so I am removing C+ here to track payments

Copy link

melvin-bot bot commented Mar 20, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

This issue has not been updated in over 15 days. @hayata-suenaga, @situchan, @smelaa eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 12, 2024
@hayata-suenaga
Copy link
Contributor Author

The PR was been merged a while ago

The only thing left to do is for the payment for the C+ review role for @situchan. @situchan is OOO for April, so I'll changing the priority of this issue to monthly

@blazejkustra
Copy link
Contributor

What are the next steps here? Should we close this issue?

@hayata-suenaga hayata-suenaga added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. and removed Monthly KSv2 labels May 16, 2024
@situchan
Copy link
Contributor

I am back

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels May 22, 2024
@hayata-suenaga hayata-suenaga added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 22, 2024
Copy link

melvin-bot bot commented May 22, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hayata-suenaga
Copy link
Contributor Author

@greg-schroeder, please pay @situchan for the C+ review role for this PR

Copy link

melvin-bot bot commented May 30, 2024

@greg-schroeder, @hayata-suenaga, @situchan, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@greg-schroeder
Copy link
Contributor

Oops, sorry, missed this comment -- looking now

@greg-schroeder
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration
Projects
No open projects
Development

No branches or pull requests