[HOLD for payment 2024-03-14] [$500] iOS - Photos - Error message displayed even though the image has been downloaded

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #36154

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): vdargentotest+web021924@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Pre-requisite: on the device settings, photos access should be set to "Add Photos Only" for New Expensify app. To do this, first set it to None, go to the app and try to download an image, it will request you to change the privacy settings, redirecting you to the settings page and the option should show up.

1. Go to any chat with an image.
2. Hold onto an image in the chat and select "Download".
3. Verify an error message is displayed.

Expected Result:

A message saying that the file was successfully downloaded should be displayed.

Actual Result:

An error message is displayed, but the image is actually downloaded.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385379_1708410705309.Euxf6671_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01be2c326a20f0e643
• Upwork Job ID: 1759903796285509632
• Last Price Increase: 2024-02-20
• Automatic offers:
• mollfpr | Reviewer | 0
• shahinyan11 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01be2c326a20f0e643

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Photos - Error message displayed even though the image has been downloaded

What is the root cause of that problem?

It is the @react-native-camera-roll/camera-roll package error and only occurs when the Photo library access permission is set Add photos only . it will not happen If we set Full access .

What changes do you think we should make in order to solve the problem?

Downgrade the version of @react-native-camera-roll/camera-roll package to 7.2.2

What alternative solutions did you explore? (Optional)

1. Add this code to line 210 in the file node_modules/@react-native-camera-roll/camera-roll/ios/RNCCameraRoll.mm file and patch package

if (![createdAsset isKindOfClass:[PHAsset class]]) {
  resolve(@{
    @"node": [NSNull null]
  });
  return;
}

2. Use CameraRoll.saveAsset instead CameraRoll.save here. The save method is deprecated and it is mentioned in package codes. here

[shubham1206agra]

@shahinyan11 Can you upload a video with fixed steps?

[shahinyan11]

Proposal

Updated

[shubham1206agra]

Again, upload video of fixed behavior.

[shahinyan11]

Again, upload video of fixed behavior.

Untitled.mov

[shubham1206agra]

Sorry, one last thing. Show the same with video download.

[shahinyan11]

Sorry, one last thing. Show the same with video download.

For downloading video we have another downloadVideo function . Why you need to see it ?

[mollfpr]

@shahinyan11 I try your proposal but the error message still shown.

Simulator.Screen.Recording.-.iPhone.15.Pro.17.2.-.2024-02-21.at.00.37.48.mov

[shahinyan11]

Proposal

Updated

[thienlnam]

I downgraded the version so we can unblock deploy, but I'm reopening as we still want to upgrade this version so we unblock the New Arch upgrade

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix displaying error message when image has been downloaded #37316

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment automatic offer (Reviewer)
• @shahinyan11 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

This one's a lil confusing but I think we're just waiting 7 days for payment.
@mollfpr , please fill out the BZ checklist.

Also, @mollfpr , I'm seeing this above

@mollfpr requires payment automatic offer (Reviewer)

But... you're paid via NewDot, right? Have you ever seen the 'auto-post' that shows the correct details about payment via NewDot? If so, can you link? If not I'll see what list I need to add you to to get ya updated (already created an internal GH assigned to myself so I don't forget)

[mollfpr]

@mollfpr , please fill out the BZ checklist.

Yup!

@mallenexpensify I think I already asked someone to remove me from the Upwork list, but I don't remember the details.

Have you ever seen the 'auto-post' that shows the correct details about payment via NewDot?

I haven't seen any auto-post about payment via NewDot.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

The issue arise after #36154 is merged but mainly the main issue is on the upstream library. So we decided to patch the latest version react-native-camera-roll to quickly fix it.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

I think the regression test is enough here.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We already have the test case for downloading an image https://expensify.testrail.io/index.php?/cases/view/2644131. I'm suggesting we add one more verification on the last point for the native platform.

13. Verify the success message is displayed in iOS/Android.

[mollfpr]

@mallenexpensify Could you give the payment summary? Thank you!

[shahinyan11]

@mallenexpensify Could you please send the payment ?

[mallenexpensify]

Contributor: @shahinyan11 paid $500 via Upwork
Contributor+: @mollfpr owed $500 via NewDot

TR Update GH https://github.com/Expensify/Expensify/issues/379569
Thanks y'all.

[JmillsExpensify]

$500 approved for @mollfpr based on summary.