[HOLD for payment 2024-03-07] Desktop - App becomes unusable afterclear cache and restart

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): @mallenexpensify and @muttmuure
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708636284808519

Action Performed:

1. Go to account settings > about > troubleshoot
2. Click on "clear cache and restart"
3. Send messages after restarted

Expected Result:

Able to send messages

Actual Result:

• App isn't useable, likely because of ,"jsonCode":407," which (apparently) means auth token is expired.
• have to sign out/in, then chats start loading (which takes a while cuz it reloads all chats)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mallenexpensify]

Also.. I had to sign out/in twice in order to get all my chats to show properly in LHN. Pinned chats and tasks weren't all loading, even after 5+ hours and with hard refreshing

[trjExpensify]

Reached out to the author of #36337 here.

[TMisiukiewicz]

Hi, I would like to be assigned to this issue

[trjExpensify]

Any movement on this one, @TMisiukiewicz?

[TMisiukiewicz]

Sorry, I was on a sick leave on Monday and Tuesday, I had a discussion with @techievivek here, I'll verify this solution today and open a PR if it works fine.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: preserve credentials when clearing onyx #37401

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @TMisiukiewicz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@techievivek] The PR that introduced the bug has been identified. Link to the PR:
• [@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@TMisiukiewicz] Determine if we should create a regression test for this bug.
• [@TMisiukiewicz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Dev tool bug and no C+ review of this PR, so I'm closing it.