[HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-15
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708850630563619

Action Performed:

1. Request money
2. Enter amount
3. Select DM 1:1 chat
4. Click on description page
5. In the URL, change description to category or tag/1
   (on native app or desktop app, using deeplink)

Expected Result:

Should display Not Found Page

Actual Result:

Empty category/tag page display

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-02-25.at.15.40.13.mov

View all open jobs on GitHub

Recording.2778.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d915d40b791c907
• Upwork Job ID: 1762132134901731328
• Last Price Increase: 2024-02-26
• Automatic offers:
• mkhutornyi | Reviewer | 0
• DylanDylann | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d915d40b791c907

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Still can access to Tag page when request money to DM 1:1 chat

What is the root cause of that problem?

In IOURequestStepTag we don't pass shouldShowNotFoundPage props to StepScreenWrapper

What changes do you think we should make in order to solve the problem?

In IOURequestStepTag we should pass shouldShowNotFoundPage props to StepScreenWrapper

    const shouldShowNotFoundPage = !isPolicyExpenseChat || (!transactionTag && !OptionsListUtils.hasEnabledTags(policyTagLists)));

App/src/pages/EditRequestPage.js

Line 158 in 6cd008e

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.TAG && shouldShowTags) {

Like we did here

App/src/pages/EditRequestPage.js

Line 92 in 6cd008e

const shouldShowTags = useMemo(() => isPolicyExpenseChat && (transactionTag || OptionsListUtils.hasEnabledTags(policyTagLists)), [isPolicyExpenseChat, policyTagLists, transactionTag]);

What alternative solutions did you explore? (Optional)

[lschurr]

Could you review this one @mkhutornyi?

[DylanDylann]

@mkhutornyi For more information, recently we have 2 issues:

• Issue 1 [HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js #34606 : Remove old category page and migrate logic to IOURequestStepCategory
• Issue 2 [HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612 : Remove old tag page and migrate logic to IOURequestStepTag

In issue 1, I am a C+ contributor and I see that the contributor forgot to migrate the logic to display Not Found Page here. Then the contributor fixed it and currently the logic in the category is correct. After that, I saw that the same problem still happens on the Tag Page. It is the reason why I report this bug

[mkhutornyi]

Empty category/tag page display is not actual result right now.

The remaining bug to fix is make tag page same as category page when not found

[DylanDylann]

@mkhutornyi Because this PR is deployed to staging, the behavior on category page is correct

The remaining bug to fix is make tag page same as category page when not found

Yes, we only need to fix this bug on Tag Page

[mkhutornyi]

@DylanDylann's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jasperhuangg]

I agree that @DylanDylann's proposal looks good and they should be assigned to this issue!

[DylanDylann]

@mkhutornyi The PR is ready for review: #37747

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/37207: Display not found page instead Tag Page #37747

If no regressions arise, payment will be issued on 2024-03-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi / @DylanDylann] Determine if we should create a regression test for this bug.
• [@mkhutornyi / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Could you work on the checklist for this one @mkhutornyi?

[mkhutornyi]

1. The PR that introduced the bug has been identified. Link to the PR: Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176
2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37176/files#r1525400140
3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
4. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Yes
5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal:

1. FAB > Request money
2. Enter any amount
3. Select DM 1:1 chat
4. Click on description page
5. In the URL, change description to category or tag/1
6. Verify that not found page shows

[lschurr]

Payment summary:

• Contributor: @DylanDylann $500 (paid in Upwork)
• Contributor+: @mkhutornyi $500 (paid in Upwork)