[HOLD for payment 2024-03-20] [$500] Settings - I get an "about:blank" page after navigating to the macOS link

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR : #29991

Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

1. Navigate to Settings - About - App download links - macOS
2. Tap on the "X" button

Expected Result:

I should be returned to Expensify after tapping on the "X" buttor or I should be able to use the back button to navigate back.

Actual Result:

I get an "about:blank" page after navigating to the macOS link. I can't use the browsers back button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6395100_1709099144625.BMDX3142.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0175806b466ff4d5e7
• Upwork Job ID: 1764768337906176000
• Last Price Increase: 2024-03-04

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[sakluger]

I agree this is a bug, since on the mobile app, we close the browser tab after clicking x.

I would say that this is #vip-vsb, I'll add to that dashboard as low priority.

[melvin-bot]

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sakluger]

I'm going to go ahead and make this external - if it must be handled internally, let me know.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0175806b466ff4d5e7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I get an "about:blank" page after navigating to the macOS link. I can't use the browsers back button.

What is the root cause of that problem?

When opening an URL in web, by default we'll always open a new about:blank tab in Safari to avoid Safari blocking the opening popup in async call, see here.

We're applying that behavior to download links opening as well although the links are opened in a synchronous call, not an async call so will not have that problem.

What changes do you think we should make in order to solve the problem?

Pass shouldSkipCustomSafariLogic as true here so it will open normally in Safari without opening an about:blank tab.

We can consider applying the same for other download links (or any links that are not being opened asynchronously)

What alternative solutions did you explore? (Optional)

Out of scope but if we want the download to be triggered in the current tab itself instead of opening in the new tab, we should allow customizing the target to be passed into Linking.openURL, and in case of download links, we should set target to _self.

Also I think it's better to pass undefined rather than Promise.resolve() here, and handle the case where there's no promise to be resolved inside openExternalLink. This is to make it clear that there's no promise/async in that case.

[allroundexperts]

@tienifr's proposal looks good to me. I think we should just focus on the bug on hand in this PR.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[manishjain999]

When clicking the the link for macOS - the link is actually pointing to "NewExpensify.dmg" file and the mobile app tries to download that directly. The link should instead be to a download page URL like - https://use.expensify.com/download where the page opens and which then initiates a download on opening, then the "about:blank" issue should be resolved.

Contributor details
Your Expensify account email: manishjain9@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01c500bbbfa53546df

[melvin-bot]

📣 @manishjain999! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

[lakchote]

@tienifr's proposal LGTM. Thanks @allroundexperts for reviewing.

[lakchote]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

@sakluger can you make the offer to the contributor? Thanks!

[sakluger]

Looks like we did send an offer to @tienifr (https://www.upwork.com/nx/wm/offer/101278408). So the automation worked but didn't realized it worked 😄.

[tienifr]

PR ready for review #38032.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: about:blank page opens in download app link on Safari #38032

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $500 via NewDot
• Contributor: @tienifr sent offer of $500 via Upwork (LINK)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1764768337906176000/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

@allroundexperts could you please complete the BZ checklist?

@tienifr I sent you an offer through Upwork, please let me know when you've accepted it. Thanks!

[tienifr]

@sakluger I accepted the offer, thanks!

[allroundexperts]

Checklist

1. Fix: Safari App Store Link Redirect #11110
2. https://github.com/Expensify/App/pull/11110/files#r1534762717
3. N/A
4. A regression test would be helpful here. The steps given in the OP look good enough to me.

[sakluger]

Thanks @tienifr - all paid out.

@allroundexperts feel free to request payment via newdot.

[JmillsExpensify]

$500 approved for @allroundexperts