[HOLD for payment 2024-05-06] [$250] [Held requests] Hold request link for the requestee shows "undefined"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Request money from User B
3. [User B] Navigate to request details page
4. [User B] Click 3-dot menu > Hold request

Expected Result:

There will be no "undefined" in Hold request link

Actual Result:

Hold request link for the requestee shows "undefined"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6397422_1709230911407.20240301_004031.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166aa9b176af4b313
• Upwork Job ID: 1766289313058312192
• Last Price Increase: 2024-04-06

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request reason link includes undefined

What is the root cause of that problem?

We are passing policy type here instead of the iouType and for a non-active policy it will be undefined empty after the TS migration PR. Due to that, it will form the incorrect route without iouType and lead to the not found page.
If we see the getRoute of the ROUTES.MONEY_REQUEST_HOLD_REASON it expects the first parameter should be the iouType not the policyType.

App/src/components/MoneyRequestHeader.tsx

Line 98 in 9e40a11

Navigation.navigate(ROUTES.MONEY_REQUEST_HOLD_REASON.getRoute(policy?.type ?? '', iouTransactionID, report?.reportID, activeRoute));

App/src/ROUTES.ts

Lines 301 to 304 in bae502e

	MONEY_REQUEST_HOLD_REASON: {
	route: ':iouType/edit/reason/:transactionID?',
	getRoute: (iouType: string, transactionID: string, reportID: string, backTo: string) => `${iouType}/edit/reason/${transactionID}?backTo=${backTo}&reportID=${reportID}` as const,
	},

What changes do you think we should make in order to solve the problem?

Pass CONST.IOU.TYPE.REQUEST instead of policy?.type here to correct the iouType. We aren't using this route param value in the hold page but to be consistent with other routes we need to pass iouType.

[greg-schroeder]

Checking w/ the team on this one

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0166aa9b176af4b313

[greg-schroeder]

Setting to External per team discussion

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Upwork job price has been updated to $250

[damadoko]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request reason link includes undefined

What is the root cause of that problem?

• The policyID of a Chat report is created by the requestor's personal policyID (in the BE side).
• Each account only has 1 personal policyID. That mean when the receiver open above report, the report policyID will not found in receiver's policy list, it will fallback to {}:

  App/src/pages/home/ReportScreen.js

  Line 280 in 9302ade

  const policy = policies[`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`] || {};

• That empty policy was passed to the navigate param, which cause the undefined value included in the link:

  App/src/components/MoneyRequestHeader.tsx

  Line 90 in 9302ade

  Navigation.navigate(ROUTES.MONEY_REQUEST_HOLD_REASON.getRoute(policy?.type, parentReportAction?.originalMessage?.IOUTransactionID ?? '', report?.reportID, activeRoute));

What changes do you think we should make in order to solve the problem?

I think we need to pass CONST.POLICY.TYPE.PERSONAL as the fallback value:

 Navigation.navigate(ROUTES.MONEY_REQUEST_HOLD_REASON.getRoute(policy?.type ?? CONST.POLICY.TYPE.PERSONAL, parentReportAction?.originalMessage?.IOUTransactionID ?? '', report?.reportID, activeRoute));

Because currently, we only have 4 type of policies, other type free, corporate, team are workspace's policy. Therefore, these policy type always available in both requester and receiver. This bug only happen in receiver side in P2P request money flow.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@sobitneupane, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sobitneupane]

In latest main, when I try to reproduce the issue, the app crashes. Is it related to this issue? Or is there any other open issue to resolve it?

Screen.Recording.2024-03-13.at.14.47.59.mov

[bernhardoj]

It shows not found page since this TS PR where it puts an empty string as the default value. There is an issue for that here, but basically they are the same issue.

[sobitneupane]

@bernhardoj Do you mean #38345 issue and #37554 issue are same?

[bernhardoj]

I would say they are the same and @Pujan92 solution will solve it.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Hi! I think this sounds good, but I'm going to take a little more time to confirm, since I just came back from leave and the Hold Request flow didn't exist when I left - so I have to get more familiar with it!

[greg-schroeder]

Thanks @dangrous! Let us know if you need more eyes 👍

[dangrous]

Okay, I think this makes sense to me! Thanks for your patience. I may have a couple questions along the way but let's move forward.

[melvin-bot]

❌ There was an error making the offer to @GandalfGwaihir for the Contributor role. The BZ member will need to manually hire the contributor.

[allgandalf]

PR Update: waiting on @dangrous to merge the PR, I Think he's OoO :)

[dangrous]

Yep! I was out, looking at this shortly.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix]: Requestee cannot hold requests in 1:1 IOU transactions  #40319

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @GandalfGwaihir requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#33897

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#33897 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#37554 (comment)

[sobitneupane]

Regression Test Proposal

1. Login from one account
2. Request money 1:1 with the same user 2 times
3. Login from that other account to which you have requested money
4. Open chat and navigate to any one of the money request by the previously logged in user.
5. Hold the request
6. Verify that you can successfully hold the request.

Do we agree 👍 or 👎

[greg-schroeder]

Processing

[greg-schroeder]

$250 - C+ - @sobitneupane - you can make a ND manual request for payment
$250 - C - @GandalfGwaihir - I've sent you a manual offer for this issue, can you please accept it in upwork? Thanks!

I'll now file the regression test.

[allgandalf]

I've sent you a manual offer for this issue, can you please accept it in upwork? Thanks!

Have accepted the offer, thanks :)

[JmillsExpensify]

$250 approved for @sobitneupane