[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room

[stitesExpensify]

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.g77lx534xj1g

A new component, TripDetailsView will be created in src/components/ReportActionItem:

• It will display and behave mimicking MoneyReportView’s behavior.
• A new chat type, ​​POLICY_TRIP_ROOM, will be added to CONST.ts.
• A new helper function, isTripRoom(report) will be added to ReportUtils. It will return true if the provided report type is CONST.REPORT.TYPE.CHAT, and the chat type is the new CONST.REPORT.CHAT_TYPE.​​POLICY_TRIP_ROOM
• It will be displayed from ReportActionItem if isTripRoom returns true.
• It will take the associated expense report as parameter and:
• Use the new getTripTransactions function to retrieve all transactions with trip data to display.
• Display them as shown above using the existing MenuItemWithTopDescription like we do for money reports.
• On click, it will open the trip details panel via a new route, ROUTES.TRAVEL_DETAILS

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

Issue Owner

Current Issue Owner: @twisterdotcom

[WojtekBoman]

Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue.

[twisterdotcom]

Adding a C+ here for Travel reviews: @shubham1206agra

[twisterdotcom]

Only assigned on Friday. We can give them a day here Melvin.

[melvin-bot]

@twisterdotcom, @WojtekBoman, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Are we waiting on anything internal here?

[smelaa]

Hi! I'm Aleksandra from Software Mansion, the expert agency, and I would like to take it over from Wojtek and work on this issue.

[twisterdotcom]

@smelaa only assigned on Friday.

[WojtekBoman]

@twisterdotcom @shawnborton @dannymcclain @stitesExpensify
Hi! I have some questions regarding this issue :) I've marked on the screenshot elements related to the questions below.

1. What should the rows with travel details look like when hovering over these elements? I'm specifically asking about the background color of the icon, I'm also attaching a screenshot showing the current hover style of this element.
2. I need to know the logic for displaying date text. Could you please give me similar examples as here for different years, months etc?
3. Which field from this data structure should be used to display this text (record locator)? If it's not known yet, can we adjust it once the backend is ready?

[shawnborton]

We have a value in our color system for rowHover, which is product300. If you use that, we shouldn't get any collisions with the icon BG color:

[WojtekBoman]

@shawnborton @dannymcclain

I need to know the logic for displaying date text. Could you please give me similar examples as here for different years, months etc?

Could you take a look at it when you have time? :)

[dannymcclain]

I would just use the same? Not sure why they would be different. Will definitely let Shawn weigh in too, but I can't think of a reason for them using different date formatting.

[shawnborton]

Yeah that's my thinking too. I think if you are looking at a date that has a year other than the current year we are in, it should show the year. But if you are looking at a date within the current year, no need to show the year.

[WojtekBoman]

Ok, I asked because I had noticed on the designs that the date text also includes the day name, flight time, etc. and I was wondering if I could apply the same rules for date text displaying which was used for TripRoomPreview.

[shawnborton]

Oh, are you asking about the date here for instance?

[rushatgabhane]

Updates here - https://expensify.slack.com/archives/C05S5EV2JTX/p1716196862504789?thread_ts=1715723531.626149&cid=C05S5EV2JTX

waiting for car pickup address from backend

[rushatgabhane]

@shubham1206agra this is ready for your review. There are a few backend issues here and here but it shouldn't block anything.

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [VIP-Travel] Trip room summary #41659

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @WojtekBoman does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)
• @smelaa does not require payment (Contractor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [VIP-Travel] Trip room summary #41659

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @WojtekBoman does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)
• @smelaa does not require payment (Contractor)

[rushatgabhane]

PR hit production 5 days ago.

[rushatgabhane]

@shubham1206agra please complete checklist for this one to add regression steps for a new feature.

[shubham1206agra]

@rushatgabhane New feature. No need for a checklist here. I believe tests are being handled separately in the doc.

[rushatgabhane]

@twisterdotcom could you please attach payment summary 🙇

[twisterdotcom]

Payment Summary: ($500 as originally this was CRITICAL):

• @rushatgabhane paid $500 via newDot requests
• @shubham1206agra paid $500 here

[shubham1206agra]

@twisterdotcom Offer accepted

[JmillsExpensify]

$500 approved for @rushatgabhane