[CRITICAL] [VIP-Travel] Create workspace address page and section in overview

[stitesExpensify]

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.9gtuxny77xql

This issue is for creating the new workspace address page:

• A new MenuItemWithTopDescription will be added to WorkspaceOverviewPage to display the Company address as shown above. On click, it’ll open WorkspaceOverviewAddressPage.
• A new page, WorkspaceOverviewAddressPage will be created, with a new route, ROUTES.WORKSPACE_PROFILE_ADDRESS. It will mostly mimic AddressPage.js with a couple of changes:
• Instead of receiving the user’s personal details, it’ll receive the workspace data, including the address.
• Instead of calling PersonalDetails.UpdateAddress, it will call a new function, Policy.updateAddress.
  Policy.updateAddress will behave much like Policy.updateWorkspaceCustomUnitAndRate, but it will call a new command, UpdateWorkspaceAddress.
• The PHP layer will be updated to receive the new command in api.php, and it will call a new function, PolicyAPI::updateWorkspaceAddress, which, in turn, will call a new Auth command.. [WIP]
• The current Policy.updateGeneralSettings… [WIP]

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

[smelaa]

Hello, I'm Aleksandra from Software Mansion, the expert agency, and I'd like to work on this issue.

[twisterdotcom]

Adding a C+ here for Travel reviews: @shubham1206agra

[twisterdotcom]

Only assigned on Friday. We can give them a day here Melvin.

[smelaa]

Hi,

Instead of receiving the user’s personal details, it’ll receive the workspace data, including the address.

Could you please let me know under which prop can I find that address? Is it already implemented?

[stitesExpensify]

The address is not implemented yet. It will be a field on the policy object

[twisterdotcom]

Draft PR above.

[smelaa]

Would you me to make the changes visible only for Spotnana Travel beta users?

[stitesExpensify]

Yes please!

[twisterdotcom]

How is this one coming along @smelaa?

[twisterdotcom]

Still waiting on webhooks.

[smelaa]

@twisterdotcom I was OOO last week. The PR draft is ready, just waiting to be connected to backend.

[twisterdotcom]

Waiting on the backend.

[stitesExpensify]

Correct we just need this API endpoint https://github.com/Expensify/Expensify/issues/385614#issuecomment-2057322402

[twisterdotcom]

This is unblocked now right? Let's get this one moving @smelaa!

[twisterdotcom]

Can we make this ready for review yet @smelaa?

[smelaa]

@stitesExpensify @twisterdotcom Can I have more details on this API endpoint? I think the linked issue is internal and I can't see the link.

[Gonals]

Discussed it via DM, but posting here for visibility.

For the endPoint, it requires 2 parameters (besides the AuthToken):

• policyID

• data, which is an array with the address containing:

addressStreet (the street name and number, like "1234 Any Street". Secondary address line, if any, should be separated by a newline (\n) character)

city

country

state

zipCode

[twisterdotcom]

Update: https://expensify.slack.com/archives/C05S5EV2JTX/p1714085472583259?thread_ts=1713825690.019579&cid=C05S5EV2JTX

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[lakchote]

cc @smelaa looks like a lot of blockers are related to it

[shubham1206agra]

@lakchote This feature is behind beta. So you can remove the deploy blocker label from them.

[twisterdotcom]

This is already live!

[shubham1206agra]

@twisterdotcom This issue still requires payment.

[twisterdotcom]

Ah! Didn't realise this was linked to a PR, thought it was one of those handled in another issue. Found it: #38381

[twisterdotcom]

Payment Summary:

• @smelaa does not require payment (Contractor)
• @shubham1206agra paid $250 here (C+)