[$250] [HOLD for payment 2024-04-03] [Simplified Collect] [Workflows] Connect bank account label is too small in Workspace > Workflows

[lakchote]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: NA
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710853970755619

Action Performed:

1. Go to Workspace settings and enable Workflows.
2. From here, enable "Make or track payments"

Expected Result:

The default label for "Connect bank account" should be in 15px font size.

Actual Result:

The label is in 13px font.

Workaround:

NA, pertains to font-size.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01058f2b7b8cc824a4
• Upwork Job ID: 1770120433483059200
• Last Price Increase: 2024-04-26

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Connect bank account label is too small in Workspace > Workflows

What is the root cause of that problem?

This is due to the usage of the wrong component. Used MenuItem instead of MenuItemWithTopDescription.

Line

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 155 in e34f10e

<MenuItem

What changes do you think we should make in order to solve the problem?

Replace MenuItem with MenuItemWithTopDescription, and adjust the usage accordingly.

Sample

<MenuItemWithTopDescription
    description={hasVBA ? translate('common.bankAccount') : translate('workflowsPage.connectBankAccount')}
    title={state === BankAccount.STATE.OPEN ? bankDisplayName : undefined}
    onPress={() => navigateToBankAccountRoute(route.params.policyID, ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID))}
    shouldShowRightIcon
    wrapperStyle={containerStyle}
    hoverAndPressStyle={[styles.mr0, styles.br2]}
/>

Similar change should be made to

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 172 in e34f10e

<MenuItem

Result

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01058f2b7b8cc824a4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

[lakchote]

@shubham1206agra thanks for your proposal but this will be dealt internally as it's a small change and I've assigned myself right from the start.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Simplified Collect] [Workflows] Connect bank account label is too small in Workspace > Workflows  #38611

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: feat: Workflow payer page #37629
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37629/files#r1551133005
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Workspace settings and enable Workflows.
2. From here, enable "Make or track payments"
3. Verify that the Connect bank account label is 15px font size

Do we agree 👍 or 👎

[jjcoffee]

@kevinksullivan Friendly bump for payment 🙇

[jjcoffee]

@kevinksullivan Another friendly bump 🙇

[jjcoffee]

@kevinksullivan Would you be able to process payment on this please? Thanks 🙏

[jjcoffee]

Just to note that this issue is from before the change in the default payment, so this one should be $500 cc @kevinksullivan.

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

offer sent @jjcoffee lmk when you accept

https://www.upwork.com/jobs/~01c41af72ecd13262c

[jjcoffee]

@kevinksullivan Accepted, thanks!

[shawnborton]

Not overdue, just finalizing payments.

[kevinksullivan]

all set!