Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage pages to TypeScript #38915

Closed
fabioh8010 opened this issue Mar 25, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Typescript Migration

Comments

@fabioh8010
Copy link
Contributor

fabioh8010 commented Mar 25, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

  • src/pages/iou/request/step/IOURequestStepTaxRatePage.js
  • src/pages/iou/request/step/IOURequestStepTaxAmountPage.js
Issue OwnerCurrent Issue Owner: @kevinksullivan
Issue OwnerCurrent Issue Owner: @kevinksullivan
Issue OwnerCurrent Issue Owner: @kevinksullivan
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bd5245d23e9e6994
  • Upwork Job ID: 1783579581713768448
  • Last Price Increase: 2024-04-25
@fabioh8010 fabioh8010 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 25, 2024
@fabioh8010
Copy link
Contributor Author

This issue is internal and will be handled by the TS team.

Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link

melvin-bot bot commented Apr 2, 2024

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@jjcoffee
Copy link
Contributor

jjcoffee commented Apr 2, 2024

@kevinksullivan When you get a minute, could you assign me to the issue for future payment? I reviewed the linked PR.

Copy link

melvin-bot bot commented Apr 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rlinoz
Copy link
Contributor

rlinoz commented Apr 12, 2024

This is deployed to prod already.

@rlinoz rlinoz added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 12, 2024
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 18, 2024
@jjcoffee
Copy link
Contributor

@kevinksullivan Friendly bump for payment! 🙏

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

@rlinoz, @kevinksullivan, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Apr 25, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage pages to TypeScript [$250] [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage pages to TypeScript Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bd5245d23e9e6994

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

@kevinksullivan
Copy link
Contributor

Offer sent @jjcoffee lmk when you accept!

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
@jjcoffee
Copy link
Contributor

@kevinksullivan Accepted, thanks!

@jjcoffee
Copy link
Contributor

@kevinksullivan Whilst I have you, could you also process payment on #38584? It's been hanging around for a while, I think it's dropped off your radar because the automation failed. Thanks 🙏

@kevinksullivan
Copy link
Contributor

yup, will do. All set here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Typescript Migration
Projects
Development

No branches or pull requests

6 participants