[HOLD for payment 2024-04-25] [$250] [HOLD for payment 2024-04-17] [Android] VisionCamera not displaying when permission first given

[Julesssss]

Problem

When first approving the camera permission, the camera doesn't display:

• Create a non-scan money request to someone
• Remove camera permissions
• Kill and reopen app
• Tap request money
• Try to scan receipt
• Permission prompt is shown
• Choose 'Just this time'
• Camera view remains black
• Close the page, then reopen it
• Camera view works as expected

We're resolving this seperately as discussed here.

314057395-c4f31173-ca78-446f-9f7f-c256fc6fd68e.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cf28de4f7cebf39a
• Upwork Job ID: 1779703287335849984
• Last Price Increase: 2024-04-15
• Automatic offers:
• DylanDylann | Contributor | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mrousavy]

👋

[greg-schroeder]

Hey @Julesssss this will be Internal right? Or handled by an agency?

[Julesssss]

@mrousavy from Margelo is handling this one for, so it's external but not open to contributors

[greg-schroeder]

Based on roadmap I would guess #wave-collect makes the most sense

[greg-schroeder]

Assigning @mrousavy per #38796 (comment)

[mrousavy]

Isn't this a duplicate of #39043?

[Julesssss]

Thanks I closed the other one

[chrispader]

The problem here, is that useTabNavigatorFocus() gives us a current tabIndex of 0 instead of 1 once we render the NavigationAwareCamera. Because it is 0 and not 1, isCameraActive will be false and therefore the camera will not be activated.

App/src/pages/iou/request/step/IOURequestStepScan/NavigationAwareCamera/index.native.js

Line 13 in e4eead3

const isCameraActive = useTabNavigatorFocus({tabIndex: cameraTabIndex});

I suppose, the reason for this is that because we just requested camera permissions, which opens up the system Android dialog, the logic in @react-navigation/material-top-tabs will not calculate the correct position somewhere in this file/package: https://github.com/react-navigation/react-navigation/blob/main/packages/react-native-tab-view/src/PanResponderAdapter.tsx

I will try to update the react-navigation patch later today. A dirty hack to fix this in the Expensify codebase would be to just programmatically "swipe" between the tabs by like 1px. This will trigger the logic again and the tabIndex will be updated.

[melvin-bot]

@Julesssss @mrousavy @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

Pending @mrousavy's progress here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cf28de4f7cebf39a

[greg-schroeder]

Adding External to create an upwork job

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[greg-schroeder]

Offer sent to @DylanDylann for the C+ role

[DylanDylann]

@greg-schroeder As this announcement

Any issues created before this date will maintain their original stated price.

Should we update the original price of this issue to $500?

[greg-schroeder]

You can just accept the offer, I'll pay an extra $250 as a bonus on 4/17

[DylanDylann]

@greg-schroeder accepted. Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: IOU Request scan camera not displaying when permission first given #39854

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @mrousavy does not require payment (Contractor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Paid

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖