[HOLD for payment 2024-04-25] [$500] Workspace - The user can skip validation of the first name field on the Personal info tab

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4445017&group_by=cases:section_id&group_id=283225&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

1. Log in with a new expensifail account
2. Create a workspace
3. Navigate to Workspace settings - Bank account - Connect online with Plaid
4. Choose Regions bank
5. Continue until legal name is asked
6. Leave the first name blank and input "Charleson" to the last name
7. Tap on the "Next" button
8. Tap on the "back" button
9. Tap on the "Next" button
10. Continue the flow until you get the "firstName is invalid or missing" error

Expected Result:

The field should be validated.

Actual Result:

The user can skip validation of the first name field on the Personal info tab. "Bank account can't be created, firstName is invalid or missing" error message appears later in the flow.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6424896_1711259142194.XKMK1639.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c8adbf72aee79603
• Upwork Job ID: 1774914745105002496
• Last Price Increase: 2024-04-01
• Automatic offers:
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think this issue might be related to the #collect project.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can skip the legal name form after filling the last name, go back and reconfirm the routing number again.

What is the root cause of that problem?

We have getInitialSubstepForPersonalInfo to decide the sub-step index to show to the user.

App/src/pages/ReimbursementAccount/utils/getInitialSubstepForPersonalInfo.ts

Lines 9 to 16 in 4bc6744

	function getInitialSubstepForPersonalInfo(data: RequestorStepProps): number {
	if (data[personalInfoKeys.FIRST_NAME] === '' && data[personalInfoKeys.LAST_NAME] === '') {
	return 0;
	}
	if (data[personalInfoKeys.DOB] === '') {
	return 1;
	}

If the first name and last name are empty, we will show the legal name form. However, if we fill in the last name, it will be saved to the draft and we check for both draft and server value

App/src/pages/ReimbursementAccount/PersonalInfo/PersonalInfo.tsx

Line 47 in 4bc6744

const values = useMemo(() => getSubstepValues(PERSONAL_INFO_STEP_KEYS, reimbursementAccountDraft, reimbursementAccount), [reimbursementAccount, reimbursementAccountDraft]);

and the condition will fail because it needs both fields to be empty.

What changes do you think we should make in order to solve the problem?

Show the legal name form if one of the first or last names is empty.

if (data[personalInfoKeys.FIRST_NAME] === '' || data[personalInfoKeys.LAST_NAME] === '') {
    return 0;
}

What alternative solutions did you explore? (Optional)

Don't check for the draft data.

App/src/pages/ReimbursementAccount/PersonalInfo/PersonalInfo.tsx

Line 47 in 4bc6744

const values = useMemo(() => getSubstepValues(PERSONAL_INFO_STEP_KEYS, reimbursementAccountDraft, reimbursementAccount), [reimbursementAccount, reimbursementAccountDraft]);

const values = useMemo(() => getSubstepValues(PERSONAL_INFO_STEP_KEYS, null, reimbursementAccount), [reimbursementAccount, reimbursementAccountDraft]);

OR

Always starts from 0 (the legal name form).

App/src/pages/ReimbursementAccount/PersonalInfo/PersonalInfo.tsx

Line 54 in 4bc6744

const {componentToRender: SubStep, isEditing, screenIndex, nextScreen, prevScreen, moveTo, goToTheLastStep} = useSubStep({bodyContent, startFrom, onFinished: submit});

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c8adbf72aee79603

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[johncschuster]

I'm not sure how this fits into any of our existing initiatives, but this feels like either an oversight or a regression if the user can skip ahead of entering their first name in the form.

[sobitneupane]

Thanks for the proposal @bernhardoj.

Proposal from @bernhardoj looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@johncschuster, @sobitneupane, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @sobitneupane

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix user can skip legal name form in workspace bank account page #39786

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Payment Summary:

@sobitneupane - $500 - via NewDot Manual Requests
@bernhardoj - $500 - PAID via Upwork (Contributor)

[johncschuster]

@sobitneupane, can you complete the BZ Checklist above? Thank you!

[melvin-bot]

@johncschuster, @sobitneupane, @grgia, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Waiting on the BZ Checklist to be completed 👍

[melvin-bot]

@johncschuster, @sobitneupane, @grgia, @bernhardoj Eep! 4 days overdue now. Issues have feelings too...

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#31121

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#31121 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#38920 (comment)

[sobitneupane]

Regression Test Proposal

1. Open Settings > Workspaces > Select any workspace > Bank account
2. Connect manually
3. Complete the routing and bank account number step
4. Fill the last name but leave first name empty
5. Go back
6. Go next again and confirm the routing and bank account number again
7. Verify you are navigated to the first and last name step

[sobitneupane]

Requested payment in newDot.
#38920 (comment)

[JmillsExpensify]

$500 approved for @sobitneupane