[HOLD for payment 2024-05-02] [$250] Workspace features - App shows two not here pages when opening inaccessible feature page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to feature page of a workspace in which user is not a member. (https://staging.new.expensify.com/settings/workspaces/CE183C61DF23465B/distance-rates
   )

Expected Result:

App will show not here page in full screen

Actual Result:

App shows not here page on the left and right

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a372bbcef3dbf2a7
• Upwork Job ID: 1773511214615310336
• Last Price Increase: 2024-03-29
• Automatic offers:
• alitoshmatov | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace features - App shows two not here pages when opening inaccessible feature page

What is the root cause of that problem?

We are using NotFoundPage inside PaidPolicyAccessOrNotFoundComponent & AdminPolicyAccessOrNotFoundComponent. We need to use FullPageNotFoundView.

App/src/pages/workspace/PaidPolicyAccessOrNotFoundWrapper.tsx

Line 53 in 9dbec73

return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))} />;

App/src/pages/workspace/AdminPolicyAccessOrNotFoundWrapper.tsx

Line 53 in 9dbec73

return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))} />;

What changes do you think we should make in order to solve the problem?

We need to use FullPageNotFoundView with shouldShow & shouldForceFullScreen just like we don in FeatureEnabledAccessOrNotFoundComponent.

Pseudo-code:

<FullPageNotFoundView
    shouldShow={shouldShowNotFoundPage}
    shouldForceFullScreen=
    onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))}
/>

There might be few more similar bugs, will try to find and fix those as well.

Optional: We might only want to do this in PaidPolicyAccessOrNotFoundComponent only.

Result

[Krishna2323]

Proposal updated

• Added references

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a372bbcef3dbf2a7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App shows not here page on the left and right

What is the root cause of that problem?

In here and here, we only show the NotFoundPage which will cover only the main part of the screen, not the left WorkspaceInitialPage.

The reason for that is because, if the user has access to the policy, they have access to the WorkspaceInitialPage too, just not the specific workspace page in the main UI (because that user is not and admin or the workspace is not a paid one). So it makes sense to show NotFound page only in the main UI so the user could still navigate to other accessible workspace tabs if they want to. We can also see that our intention was to navigate to the workspace profile page of that workspace in onBackButtonPress (see here), so we are expecting here that the user access to the workspace already.

But this is not always true, there're scenario where the user don't actually have access to that workspace at all (non-existent workspace or the user is not a member of that workspace). In this case the user won't see the left- WorkspaceInitialPage too, so it shows as 2 NotFoundPages.

What changes do you think we should make in order to solve the problem?

We should make clear of 2 scenarios:

1. If the user doesn't have access to the workspace: We need to show the FullPageNotFoundView that covers the full screen (not 2 not found pages as we do now), and when the user clicks back press, we should goBack with the workspace list pages as fallback (or home screen, depending on team's decision). We can't goBack with workspace profile page as we're doing here, because the user won't have access even to that profile page so that will be another not found screen when the user clicks on back press.
2. If the user has access to the workspace, but not the specific page they're trying to get in: Show not found page in the main UI as currently (the left- WorkspaceInitialPage should still be accessibile)

We can do that by updating here to

if (shouldShowNotFoundPage) {
    const isPolicyNotAccessible = isEmptyObject(props.policy) || !props.policy?.id;

    if (isPolicyNotAccessible) {
        return <FullPageNotFoundView
            shouldShow
            shouldForceFullScreen
            onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
        />
    }
    return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))} />;
}

isPolicyNotAccessible is same condition being checked in here, we can extract out and reuse.

(Do the same in PaidPolicyAccessOrNotFoundComponent, or in FeatureEnabledAccessOrNotFoundComponent too if we want)

What alternative solutions did you explore? (Optional)

We can show FullPageNotFoundView for both scenarios listed above, but importantly we need to goBack to the correct page. Either always go back to ROUTES.SETTINGS_WORKSPACES or go back to ROUTES.SETTINGS_WORKSPACES if workspace is not accessibile, and to ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID) if workspace is accessible. If not there'll be a bug when doing back press.

because the user won't have access even to that profile page so that will be another not found screen when the user clicks on back press.

[greg-schroeder]

Pending proposal review @alitoshmatov

[alitoshmatov]

@Krishna2323 Thank you for your proposal, you solution causes to show not fullscreen found page always even though user has access to workspace

[alitoshmatov]

@nkdengineer Thank you for your proposal, Your RCA is correct and your solution looks good. I think going back to workspaces list is better option when user does not have access to the workspace

We can go with @nkdengineer 's proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[greg-schroeder]

Bump @youssef-lr on contributor selection :)

[youssef-lr]

LGTM as well!

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[greg-schroeder]

Linked PR is in review, needs @alitoshmatov to take a look as a next step!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: app shows full page notfound in ws features page #39835

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: Feat/categories main page #36324
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36324/files#r1585896057
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug. No need

[greg-schroeder]

@alitoshmatov paid
@nkdengineer manual offer sent, i'll pay you right away as soon as you accept!

no regression test per C+, closing accordingly.

[nkdengineer]

@greg-schroeder I accepted the offer 🙏