[HOLD #39982] Thread - Gray "Replies" does not disappear together with reply when reply is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message
4. Right click on the message > Reply in thread
5. Note that "Replies" is not present when there is no reply
6. Send a reply
7. Delete the reply

Expected Result:

When the reply is deleted, the gray "Replies" should disappear together with the deleted reply

Actual Result:

When the reply is deleted, the gray "Replies" only disappears after a while

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431598_1711719929818.Gray_repliies.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

Seems like a regression introduced in #38722

@chiragsalian @dannymcclain @allroundexperts @rayane-djouah - Would you like to block on this?

Seems like maybe we should be clearing the "Replies" optimistically as well, not just when the API replies?

[dannymcclain]

I personally don't think this should be a blocker. I think we should fix it, but it doesn't break anything or really cause any harm, so I don't think it needs to be a blocker.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the reply is deleted, the gray "Replies" only disappears after a while

What is the root cause of that problem?

We display the Replies divider when there're report actions in that report (CREATED action excluded):

App/src/pages/home/report/ReportActionsList.tsx

Line 535 in d7a0870

shouldDisplayReplyDivider={sortedReportActions.length > 1}

But sortedReportActions also includes invisible report actions like deleted ones.

What changes do you think we should make in order to solve the problem?

We should use sortedVisibleReportActions at the above place.

What alternative solutions did you explore? (Optional)

NA

[rayane-djouah]

Agree with @dannymcclain , we don't need to block on this.
The condition to display the Replies section here check if there are any report actions in the thread report in addition to the action with created type, it does not check if all report actions are deleted.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[AndrewGable]

Assigning original PR author and internal engineer to work on it as a regression.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @chiragsalian, @mallenexpensify, @rayane-djouah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mallenexpensify]

We're on hold here pending

• [HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message #39982 (comment)

@rayane-djouah just proposed a solution there today.

[rayane-djouah]

Off hold, The PR is merged, and this bug is no longer reproducible on main; we can close this issue.

[mallenexpensify]

Thanks @rayane-djouah , also confirmed it's not reproducible.