[MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat
3. Create a group chat with User B and C
4. Send a message in group chat
5. Right click on the message > Reply in thread
6. Mention User D and invite User D from Concierge whisper
7. As User D, navigate to the thread
8. As User D, click on the blue "Thread" above the parent message

Expected Result:

Since User D is not in the group chat, the blue "Thread" should be disabled

Actual Result:

The blue "Thread" is not disabled and it is clickable, which leads to not here page.
When returning to thread after clicking on the Thread button, the header subtitle shows "From" with empty destination

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6432856_1711829901488.20240331_041301.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[pecanoro]

Posted here #39343 since I think we are fixing it there.

[marcaaron]

I'm a little confused about this bug report. It seems similar to #39333 in that:

• We created a DM or Group Chat
• We are expecting that this should work a certain way
• Did we intentionally design this feature to work at all?
• Or are people able to invite users to these threads in error?

[marcaaron]

Posted here

[marcaaron]

The outcome seems to be that we can remove the blocker for now and plan how this will work.

[marcaaron]

I think it's ok to keep fixing this, but heads up I created an issue here for some backend changes to make this work correctly.

[pecanoro]

@marcaaron Did you mean to add the Reviewing label or only the Planning one?

[marcaaron]

Oh it was already on, sorry. I accidentally removed it then put it back. And meant to add only the Planning label and remove DeployBlocker labels.

[melvin-bot]

This issue has not been updated in over 15 days. @pecanoro eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[pecanoro]

I can't reproduce this one anymore so I am going to close