[HOLD for payment 2024-04-25] [Regression] Task - Duplicate task displayed after assigning task to another user & skeleton loading

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
   and log in
2. Open any chat
3. Create a task
4. Open the task details and assign the task to the user you share the task with
5. Navigate to the chat and open the task again

Expected Result:

Only the system message that the task was assigned to a user is displayed

Actual Result:

The duplicate task is displayed below the system message, after opening the task again the skeleton loading is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431612_1711720213914.Recording__352.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[nexarvo]

Created PR for the fix as this is regression from my PR.

[stephanieelliott]

PR is under active review

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stephanieelliott]

New PR is on staging! I will update with payment dates once this hits prod

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: new task created when editing task assignee #39328

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @nexarvo requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@nexarvo] Determine if we should create a regression test for this bug.
• [@nexarvo] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twisterdotcom]

@stephanieelliott how can I help here?

[stephanieelliott]

Oh sorry @twisterdotcom it looks like my little note didn't make it on here:

Reapplying the Bug label to get another BZ member on this while I am OOO til May 2. Thanks @twisterdotcom!

Heads up this is a regression from #39215, so no payment is actually due for this one. So the only thing left to do here is create an issue for the regression test (assuming @nexarvo determines we should create one) and then close this issue!

[nexarvo]

BugZero Checklist:

• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open any chat
2. Create a task
3. Open the task details and assign the task to the user you share the task with
4. Navigate to the chat and open the task again
5. Verify that a new duplicated task is not created below system message.

Do we agree 👍 or 👎