Fix/39049 shortcut self dm task #39215

nexarvo · 2024-03-28T21:15:07Z

Details

Fixed Issues

$#39049
PROPOSAL: #39049 (comment)

Tests

Go to self-DM
Create a task and assigned to self
Go to FAB
Click Assign task shortcut
Create another task which is assigned to self
Verify that no error appears in self DM report for creating second task

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to self-DM
Create a task and assigned to self
Go to FAB
Click Assign task shortcut
Create another task which is assigned to self
Verify that no error appears for creating second task

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

WhatsApp.Video.2024-03-28.at.12.47.03.AM.mp4

Android: mWeb Chrome

WhatsApp.Video.2024-03-28.at.12.47.05.AM.mp4

iOS: Native

ios-3.mp4

iOS: mWeb Safari

ios-3-web.mp4

MacOS: Chrome / Safari

2f93d786-c077-4943-a9b7-00433e040ee6.mp4

MacOS: Desktop

d2854dfd-f72e-407a-b7c0-8a9489909b44.mp4

melvin-bot · 2024-03-28T21:15:11Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-03-28T22:04:37Z

src/libs/actions/Task.ts

@@ -709,14 +718,14 @@ function setParentReportID(parentReportID: string) {
 /**
 * Clears out the task info from the store and navigates to the NewTaskDetails page
 */
-function clearOutTaskInfoAndNavigate(reportID: string, accountID = 0) {
+function clearOutTaskInfoAndNavigate(reportID: string, report: OnyxEntry<OnyxTypes.Report>, accountID = 0) {


sorry but why do we need the both report and reportid cant we just use report.reportID?

Actually sometime report is null but reportID can be task.shareDestination

Please find related discussion here

makes sense! but lets call it chatReport instead

ishpaul777 · 2024-03-28T22:05:54Z

src/libs/actions/Task.ts

    clearOutTaskInfo();
    if (reportID && reportID !== '0') {
        setParentReportID(reportID);
    }
    if (accountID > 0) {
        const accountLogin = allPersonalDetails?.[accountID]?.login ?? '';
-        setAssigneeValue(accountLogin, accountID, reportID);
+        setAssigneeValue(accountLogin, accountID, reportID, report);


same comment as above

ishpaul777 · 2024-03-28T22:24:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-29-04-13-38.mp4

Android: mWeb Chrome

Record_2024-03-29-04-17-12.mp4

iOS: Native

Screen.Recording.2024-03-29.at.4.09.27.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.4.06.57.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.3.56.13.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.3.56.13.AM.mov

melvin-bot · 2024-03-28T23:05:30Z

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

yuwenmemon · 2024-03-28T23:06:27Z

Tests were passing

OSBotify · 2024-03-28T23:13:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix/39049 shortcut self dm task (cherry picked from commit 196d245)

bernhardoj · 2024-03-30T07:50:32Z

#39260 issue from this PR. The assignee chat report is wrong.

allgandalf · 2024-08-27T05:54:00Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

@@ -178,7 +178,7 @@ function FloatingActionButtonAndPopover(props) {
                IOU.startMoneyRequest(CONST.IOU.TYPE.SEND, props.quickAction.chatReportID);
                return;
            case CONST.QUICK_ACTIONS.ASSIGN_TASK:
-                Task.clearOutTaskInfoAndNavigate(props.quickAction.chatReportID, _.get(props.quickAction, 'targetAccountID', 0));
+                Task.clearOutTaskInfoAndNavigate(props.quickAction.chatReportID, quickActionReport, _.get(props.quickAction, 'targetAccountID', 0));


We should had passed quickActionReport as undefined:

// The second parameter of clearOutTaskInfoAndNavigate is the chat report or DM report // between the user and the person to whom the task is assigned. // Since chatReportID isn't stored in NVP_QUICK_ACTION_GLOBAL_CREATE, we set // it to undefined. This will make setAssigneeValue to search for the correct report.

This caused #44388

nexarvo requested a review from a team as a code owner March 28, 2024 21:15

melvin-bot bot removed the request for review from a team March 28, 2024 21:15

melvin-bot bot requested a review from Santhosh-Sellavel March 28, 2024 21:15

nexarvo added 9 commits March 29, 2024 02:20

fix: task not working in self dm through shortcut

dbb8c41

fix: lint issue

aac0bfc

change paramter name

1f8b24d

use key to get report

e211c64

pass report to setAssigneeValue from components itself

d22e7ad

remove getChatByReportID as it is not needed

c77c635

update conditions if chat report not available

17f17ef

fix: prettier and lint issues

7c9249e

fix: lint

52e1364

nexarvo force-pushed the fix/39049-shortcut-self-dm-task branch from 775f17b to 52e1364 Compare March 28, 2024 21:22

nexarvo mentioned this pull request Mar 28, 2024

fix: task not working in self dm through shortcut #39107

Closed

50 tasks

yuwenmemon requested a review from ishpaul777 March 28, 2024 22:00

yuwenmemon assigned nexarvo Mar 28, 2024

yuwenmemon self-requested a review March 28, 2024 22:01

ishpaul777 reviewed Mar 28, 2024

View reviewed changes

update param

71f2766

ishpaul777 approved these changes Mar 28, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia March 28, 2024 22:56

yuwenmemon approved these changes Mar 28, 2024

View reviewed changes

yuwenmemon merged commit 196d245 into Expensify:main Mar 28, 2024
16 checks passed

melvin-bot bot added the Emergency label Mar 28, 2024

yuwenmemon removed the Emergency label Mar 28, 2024

OSBotify pushed a commit that referenced this pull request Mar 28, 2024

Merge pull request #39215 from nexarvo/fix/39049-shortcut-self-dm-task

3183101

Fix/39049 shortcut self dm task (cherry picked from commit 196d245)

github-actions bot mentioned this pull request Mar 28, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

melvin-bot bot mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [$500] Shortcut - Error shows up when creating second self-assigned task via Assign task shortcut #39049

Closed

6 tasks

nexarvo mentioned this pull request Mar 30, 2024

[HOLD for payment 2024-04-25] [Regression] Task - Duplicate task displayed after assigning task to another user & skeleton loading #39260

Closed

6 tasks

allgandalf reviewed Aug 27, 2024

View reviewed changes

allgandalf mentioned this pull request Aug 27, 2024

[Awaiting Payment August 27th] [$500] Chat - UX covers message #44388

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/39049 shortcut self dm task #39215

Fix/39049 shortcut self dm task #39215

nexarvo commented Mar 28, 2024

melvin-bot bot commented Mar 28, 2024

ishpaul777 Mar 28, 2024

nexarvo Mar 28, 2024

nexarvo Mar 28, 2024

ishpaul777 Mar 28, 2024

ishpaul777 Mar 28, 2024

ishpaul777 commented Mar 28, 2024 •

edited

Loading

melvin-bot bot commented Mar 28, 2024

yuwenmemon commented Mar 28, 2024

OSBotify commented Mar 28, 2024

bernhardoj commented Mar 30, 2024

allgandalf Aug 27, 2024

Fix/39049 shortcut self dm task #39215

Fix/39049 shortcut self dm task #39215

Conversation

nexarvo commented Mar 28, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

ishpaul777 Mar 28, 2024

Choose a reason for hiding this comment

nexarvo Mar 28, 2024

Choose a reason for hiding this comment

nexarvo Mar 28, 2024

Choose a reason for hiding this comment

ishpaul777 Mar 28, 2024

Choose a reason for hiding this comment

ishpaul777 Mar 28, 2024

Choose a reason for hiding this comment

ishpaul777 commented Mar 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

yuwenmemon commented Mar 28, 2024

OSBotify commented Mar 28, 2024

bernhardoj commented Mar 30, 2024

allgandalf Aug 27, 2024

Choose a reason for hiding this comment

ishpaul777 commented Mar 28, 2024 •

edited

Loading